Skip to content

Commit

Permalink
fix: remove outdated TODOs in runtime code (#6409)
Browse files Browse the repository at this point in the history 
* fix: remove outdated TODOs in runtime code

* test: update snapshot
  • Loading branch information
@chenjiahan
chenjiahan authored Apr 30, 2024
1 parent aa164b0 commit ea79a64
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
2 changes: 0 additions & 2 deletions crates/rspack_plugin_hmr/src/runtime/hot_module_replacement.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ var registeredStatusHandlers = [];
var currentStatus = "idle";

// while downloading
// TODO: not needed in rspack temporary,
// TODO: because we transfer all changed modules.
var blockingPromises = 0;
var blockingPromisesWaiting = [];

Expand Down
6 changes: 3 additions & 3 deletions packages/rspack-test-tools/tests/__snapshots__/StatsOutput.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ Rspack x.x.x compiled successfully in X s (185b80456c181897fcd5)"
exports[`statsOutput statsOutput/hot+production should print correct stats for hot+production 1`] = `
"PublicPath: auto
asset main.js 32.2 KiB [emitted] (name: main)
Entrypoint main 32.2 KiB = main.js
asset main.js 32.1 KiB [emitted] (name: main)
Entrypoint main 32.1 KiB = main.js
runtime modules 11 modules
./index.js
Rspack x.x.x compiled successfully in X s (68e01ffb94a6b5683661)"
Rspack x.x.x compiled successfully in X s (db903683225d0fe50e7b)"
`;
exports[`statsOutput statsOutput/ignore-plugin should print correct stats for ignore-plugin 1`] = `
Expand Down
2 changes: 0 additions & 2 deletions plugin-test/css-extract/cases/hmr/expected/main.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,6 @@ var registeredStatusHandlers = [];
var currentStatus = "idle";

// while downloading
// TODO: not needed in rspack temporary,
// TODO: because we transfer all changed modules.
var blockingPromises = 0;
var blockingPromisesWaiting = [];

Expand Down

3 comments on commit ea79a64

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs, self-hosted, Linux, ci ✅ success
_selftest, ubuntu-latest ✅ success
nx, ubuntu-latest ✅ success
rspress, ubuntu-latest ❌ failure
rsbuild, ubuntu-latest ✅ success
compat, ubuntu-latest ✅ success
examples, ubuntu-latest ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-04-29 ec3c0df) Current Change
10000_development-mode + exec 2.8 s ± 43 ms 2.84 s ± 29 ms +1.56 %
10000_development-mode_hmr + exec 690 ms ± 16 ms 702 ms ± 29 ms +1.76 %
10000_production-mode + exec 2.49 s ± 18 ms 2.67 s ± 35 ms +7.37 %
arco-pro_development-mode + exec 2.54 s ± 39 ms 2.65 s ± 75 ms +4.25 %
arco-pro_development-mode_hmr + exec 431 ms ± 2.6 ms 433 ms ± 3.5 ms +0.60 %
arco-pro_development-mode_hmr_intercept-plugin + exec 443 ms ± 2.5 ms 446 ms ± 6 ms +0.75 %
arco-pro_development-mode_intercept-plugin + exec 3.25 s ± 72 ms 3.46 s ± 88 ms +6.67 %
arco-pro_production-mode + exec 3.99 s ± 103 ms 4.23 s ± 79 ms +5.98 %
arco-pro_production-mode_intercept-plugin + exec 4.75 s ± 102 ms 4.99 s ± 147 ms +5.09 %
threejs_development-mode_10x + exec 2.08 s ± 23 ms 2.13 s ± 30 ms +2.40 %
threejs_development-mode_10x_hmr + exec 771 ms ± 32 ms 775 ms ± 17 ms +0.52 %
threejs_production-mode_10x + exec 5.26 s ± 54 ms 5.34 s ± 107 ms +1.40 %

Threshold exceeded: ["10000_production-mode + exec","arco-pro_development-mode_intercept-plugin + exec","arco-pro_production-mode + exec","arco-pro_production-mode_intercept-plugin + exec"]

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-04-29 ec3c0df) Current Change
10000_development-mode + exec 2.8 s ± 43 ms 2.82 s ± 30 ms +0.97 %
10000_development-mode_hmr + exec 690 ms ± 16 ms 700 ms ± 14 ms +1.46 %
10000_production-mode + exec 2.49 s ± 18 ms 2.56 s ± 55 ms +2.75 %
arco-pro_development-mode + exec 2.54 s ± 39 ms 2.62 s ± 66 ms +3.17 %
arco-pro_development-mode_hmr + exec 431 ms ± 2.6 ms 430 ms ± 2.3 ms -0.23 %
arco-pro_development-mode_hmr_intercept-plugin + exec 443 ms ± 2.5 ms 442 ms ± 3 ms -0.17 %
arco-pro_development-mode_intercept-plugin + exec 3.25 s ± 72 ms 3.42 s ± 76 ms +5.34 %
arco-pro_production-mode + exec 3.99 s ± 103 ms 4.17 s ± 49 ms +4.44 %
arco-pro_production-mode_intercept-plugin + exec 4.75 s ± 102 ms 5 s ± 73 ms +5.31 %
threejs_development-mode_10x + exec 2.08 s ± 23 ms 2.11 s ± 19 ms +1.46 %
threejs_development-mode_10x_hmr + exec 771 ms ± 32 ms 774 ms ± 7.6 ms +0.34 %
threejs_production-mode_10x + exec 5.26 s ± 54 ms 5.31 s ± 26 ms +0.99 %

Threshold exceeded: ["arco-pro_development-mode_intercept-plugin + exec","arco-pro_production-mode_intercept-plugin + exec"]

Please sign in to comment.