perf: source map dev tool plugin (#7739)

* perf: source map dev tool plugin * fix: source_map_buffer error handle
web-infra-dev · Sep 3, 2024 · ce0dab5 · ce0dab5 · rspack-bot · Sep 3, 2024
1 parent 09fe627
commit ce0dab5
Show file tree

Hide file tree

Showing 2 changed files with 173 additions and 174 deletions.
diff --git a/crates/rspack_plugin_devtool/src/module_filename_helpers.rs b/crates/rspack_plugin_devtool/src/module_filename_helpers.rs
@@ -85,12 +85,7 @@ impl ModuleFilenameHelpers {
 
         let hash = get_hash(&identifier, output_options);
 
-        let resource = short_identifier
-          .clone()
-          .split('!')
-          .last()
-          .unwrap_or("")
-          .to_string();
+        let resource = short_identifier.split('!').last().unwrap_or("").to_string();
 
         let loaders = get_before(&short_identifier, "!");
         let all_loaders = get_before(&identifier, "!");
suite	result
modernjs	✅ success
_selftest	✅ success
nx	❌ failure
rspress	✅ success
rslib	✅ success
rsbuild	✅ success
examples	✅ success
Name	Base (2024-09-03 f9820e4)	Current	Change
10000_development-mode + exec	2.24 s ± 29 ms	2.23 s ± 31 ms	-0.41 %
10000_development-mode_hmr + exec	694 ms ± 7.5 ms	686 ms ± 8.3 ms	-1.15 %
10000_production-mode + exec	2.85 s ± 30 ms	2.86 s ± 35 ms	+0.29 %
arco-pro_development-mode + exec	1.86 s ± 70 ms	1.86 s ± 54 ms	-0.06 %
arco-pro_development-mode_hmr + exec	434 ms ± 2.9 ms	436 ms ± 4.3 ms	+0.47 %
arco-pro_production-mode + exec	3.3 s ± 96 ms	3.23 s ± 82 ms	-2.06 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.32 s ± 90 ms	3.32 s ± 67 ms	-0.23 %
threejs_development-mode_10x + exec	1.65 s ± 11 ms	1.65 s ± 19 ms	-0.19 %
threejs_development-mode_10x_hmr + exec	805 ms ± 10 ms	798 ms ± 11 ms	-0.92 %
threejs_production-mode_10x + exec	5.16 s ± 30 ms	5.15 s ± 29 ms	-0.16 %