Skip to content

Commit

Permalink
fix: align get_nested_exports_info with webpack (#6351)
Browse files Browse the repository at this point in the history
  • Loading branch information
JSerFeng authored Apr 24, 2024
1 parent d90502c commit c7ea917
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/rspack_core/src/exports_info.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ impl ExportsInfoId {
let info = self.get_read_only_export_info(&name[0], mg);
if let Some(exports_info) = info.exports_info {
return exports_info.get_nested_exports_info(Some(name[1..].to_vec()), mg);
} else {
return None;
}
}
Some(*self)
Expand Down

2 comments on commit c7ea917

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs, self-hosted, Linux, ci ❌ failure
_selftest, ubuntu-latest ✅ success
nx, ubuntu-latest ✅ success
rspress, ubuntu-latest ❌ failure
rsbuild, ubuntu-latest ❌ failure
compat, ubuntu-latest ✅ success
examples, ubuntu-latest ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-04-24 332b127) Current Change
10000_development-mode + exec 2.66 s ± 28 ms 2.71 s ± 28 ms +1.83 %
10000_development-mode_hmr + exec 682 ms ± 3.7 ms 701 ms ± 8.5 ms +2.84 %
10000_production-mode + exec 2.46 s ± 31 ms 2.57 s ± 23 ms +4.47 %
arco-pro_development-mode + exec 2.48 s ± 86 ms 2.47 s ± 61 ms -0.12 %
arco-pro_development-mode_hmr + exec 429 ms ± 1.2 ms 430 ms ± 2.1 ms +0.15 %
arco-pro_development-mode_hmr_intercept-plugin + exec 441 ms ± 5.4 ms 444 ms ± 3.1 ms +0.67 %
arco-pro_development-mode_intercept-plugin + exec 3.22 s ± 88 ms 3.24 s ± 91 ms +0.77 %
arco-pro_production-mode + exec 3.95 s ± 74 ms 4.05 s ± 97 ms +2.67 %
arco-pro_production-mode_intercept-plugin + exec 4.66 s ± 238 ms 4.85 s ± 71 ms +4.13 %
threejs_development-mode_10x + exec 2.05 s ± 16 ms 2.07 s ± 32 ms +0.57 %
threejs_development-mode_10x_hmr + exec 753 ms ± 13 ms 755 ms ± 9.8 ms +0.16 %
threejs_production-mode_10x + exec 5.14 s ± 40 ms 5.28 s ± 31 ms +2.86 %

Please sign in to comment.