Skip to content

Commit

Permalink
chore(workflow): fix permissions for prod release (#6979)
Browse files Browse the repository at this point in the history
  • Loading branch information
@chenjiahan
chenjiahan authored Jun 28, 2024
1 parent 2fd81be commit b8c1ce6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ jobs:
name: Release
permissions:
contents: write
# To publish packages with provenance
id-token: write
runs-on: ubuntu-latest
needs: build
if: ${{ github.event_name == 'workflow_dispatch' }}
Expand Down

2 comments on commit b8c1ce6

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
nx ✅ success
rspress ❌ failure
rsbuild ❌ failure
compat ❌ failure
examples ❌ failure

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-06-28 940dcb5) Current Change
10000_development-mode + exec 2.26 s ± 23 ms 2.27 s ± 28 ms +0.20 %
10000_development-mode_hmr + exec 742 ms ± 4.2 ms 742 ms ± 10 ms -0.00 %
10000_production-mode + exec 3.14 s ± 20 ms 2.99 s ± 27 ms -4.87 %
arco-pro_development-mode + exec 1.99 s ± 65 ms 1.94 s ± 73 ms -2.41 %
arco-pro_development-mode_hmr + exec 443 ms ± 2.7 ms 442 ms ± 0.91 ms -0.05 %
arco-pro_production-mode + exec 4.07 s ± 95 ms 3.62 s ± 81 ms -11.02 %
threejs_development-mode_10x + exec 1.62 s ± 13 ms 1.61 s ± 16 ms -0.40 %
threejs_development-mode_10x_hmr + exec 816 ms ± 6 ms 822 ms ± 8.8 ms +0.72 %
threejs_production-mode_10x + exec 5.99 s ± 34 ms 5.86 s ± 35 ms -2.22 %

Please sign in to comment.