Skip to content

Commit

Permalink
fix(playground/cases): replace window.onmessage with self.onmessage i…
Browse files Browse the repository at this point in the history
…n worker test case (#7431)
  • Loading branch information
shulaoda authored Aug 4, 2024
1 parent 4e666c2 commit b616f98
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/playground/cases/react/worker/src/worker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Button from "./Button";

window.onmessage = () => {
self.onmessage = () => {
Button.add();
postMessage(Button.get());
};

2 comments on commit b616f98

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rsbuild ✅ success
examples ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-08-04 4e666c2) Current Change
10000_development-mode + exec 2.32 s ± 12 ms 2.31 s ± 25 ms -0.57 %
10000_development-mode_hmr + exec 703 ms ± 5.3 ms 700 ms ± 7.6 ms -0.43 %
10000_production-mode + exec 2.86 s ± 24 ms 2.85 s ± 31 ms -0.35 %
arco-pro_development-mode + exec 1.9 s ± 71 ms 1.87 s ± 81 ms -1.68 %
arco-pro_development-mode_hmr + exec 434 ms ± 2.2 ms 433 ms ± 2.9 ms -0.31 %
arco-pro_production-mode + exec 3.43 s ± 71 ms 3.42 s ± 115 ms -0.23 %
threejs_development-mode_10x + exec 1.7 s ± 13 ms 1.7 s ± 18 ms -0.09 %
threejs_development-mode_10x_hmr + exec 811 ms ± 12 ms 812 ms ± 8.9 ms +0.20 %
threejs_production-mode_10x + exec 5.52 s ± 25 ms 5.5 s ± 24 ms -0.25 %

Please sign in to comment.