Skip to content

Commit

Permalink
chore: release run macos test when arch match (#7046)
Browse files Browse the repository at this point in the history
  • Loading branch information
jerrykingxyz authored Jul 4, 2024
1 parent 1ee6de8 commit add78bb
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,20 @@ jobs:
# if: ${{ inputs.target == 'x86_64-unknown-linux-gnu' && !inputs.skipable }}
# run: node ./scripts/test/diff.cjs

### x86_64-apple-darwin
### *-apple-darwin

- name: Test x86_64-apple-darwin
- name: Test apple-darwin
timeout-minutes: 15 # Tests should finish within 15 mins, please fix your tests instead of changing this to a higher timeout.
if: ${{ inputs.target == 'x86_64-apple-darwin' && !inputs.skipable }}
run: pnpm run test:ci
if: ${{ contains(inputs.target, 'apple-darwin') && !inputs.skipable }}
run: |
# arch is ARM and target is ARM
if [[ '${{ runner.arch }}' == ARM* && '${{ inputs.target }}' == 'aarch64-apple-darwin' ]]; then
pnpm run test:ci
fi
# arch is x64 and target is x64
if [[ '${{ runner.arch }}' != ARM* && '${{ inputs.target }}' != 'aarch64-apple-darwin' ]]; then
pnpm run test:ci
fi
### x86_64-pc-windows-msvc

Expand Down

2 comments on commit add78bb

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-07-04 b05f523) Current Change
10000_development-mode + exec 2.14 s ± 20 ms 2.15 s ± 14 ms +0.45 %
10000_development-mode_hmr + exec 689 ms ± 5.8 ms 693 ms ± 6.9 ms +0.60 %
10000_production-mode + exec 2.76 s ± 25 ms 2.81 s ± 28 ms +1.66 %
arco-pro_development-mode + exec 1.89 s ± 57 ms 1.88 s ± 84 ms -0.54 %
arco-pro_development-mode_hmr + exec 432 ms ± 2 ms 434 ms ± 0.71 ms +0.42 %
arco-pro_production-mode + exec 3.48 s ± 84 ms 3.41 s ± 64 ms -1.83 %
threejs_development-mode_10x + exec 1.6 s ± 15 ms 1.57 s ± 25 ms -1.64 %
threejs_development-mode_10x_hmr + exec 820 ms ± 8.5 ms 798 ms ± 9.8 ms -2.68 %
threejs_production-mode_10x + exec 5.58 s ± 47 ms 5.61 s ± 27 ms +0.53 %

Please sign in to comment.