Skip to content

Commit

Permalink
perf: bump miette v7 to reduce binary size (#8694)
Browse files Browse the repository at this point in the history 
* perf: bump miette v7 to reduce binary size

* fix: lint

* fix: lock file
  • Loading branch information
@chenjiahan
chenjiahan authored Dec 13, 2024
1 parent 2e65ed6 commit 993b792
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 116 deletions.
149 changes: 37 additions & 112 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/rspack_error/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ anyhow = { workspace = true, features = ["backtrace"] }
cow-utils = { workspace = true }
derivative = { workspace = true }
futures = { workspace = true }
miette = { version = "5", features = ["fancy"] }
miette = { version = "7.2.0", features = ["fancy"] }
once_cell = { workspace = true }
owo-colors = "3.5.0"
owo-colors = "4.0.0"
rspack_cacheable = { workspace = true }
rspack_collections = { workspace = true }
rspack_paths = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion crates/rspack_error/src/error.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ impl TraceableError {
message,
severity: Default::default(),
src,
label: SourceSpan::new(start.into(), end.saturating_sub(start).into()),
label: SourceSpan::new(start.into(), end.saturating_sub(start)),
help: None,
url: None,
hide_stack: None,
Expand Down
2 changes: 1 addition & 1 deletion tasks/release-check/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repository.workspace = true

[dependencies]
toml = { version = "0.8.19"}
miette = { version = "5", features = ["fancy"] }
miette = { version = "7.2.0", features = ["fancy"] }
thiserror = "1.0.69"

[lints]
Expand Down

2 comments on commit 993b792

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
rsdoctor ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ❌ failure
devserver ✅ success
nuxt ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-12-13 c81fa8d) Current Change
10000_big_production-mode_disable-minimize + exec 37.7 s ± 976 ms 37.5 s ± 468 ms -0.44 %
10000_development-mode + exec 1.79 s ± 21 ms 1.78 s ± 25 ms -0.30 %
10000_development-mode_hmr + exec 656 ms ± 7.9 ms 657 ms ± 7.1 ms +0.14 %
10000_production-mode + exec 2.33 s ± 42 ms 2.39 s ± 57 ms +2.70 %
arco-pro_development-mode + exec 1.74 s ± 73 ms 1.74 s ± 80 ms +0.24 %
arco-pro_development-mode_hmr + exec 379 ms ± 1.3 ms 379 ms ± 1 ms -0.04 %
arco-pro_production-mode + exec 3.11 s ± 87 ms 3.12 s ± 84 ms +0.30 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.17 s ± 78 ms 3.18 s ± 76 ms +0.32 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.12 s ± 93 ms 3.14 s ± 51 ms +0.58 %
threejs_development-mode_10x + exec 1.6 s ± 9.6 ms 1.58 s ± 15 ms -1.58 %
threejs_development-mode_10x_hmr + exec 789 ms ± 24 ms 769 ms ± 9.6 ms -2.57 %
threejs_production-mode_10x + exec 4.94 s ± 110 ms 4.92 s ± 44 ms -0.41 %
10000_big_production-mode_disable-minimize + rss memory 9737 MiB ± 290 MiB 9537 MiB ± 21.8 MiB -2.05 %
10000_development-mode + rss memory 808 MiB ± 16.8 MiB 806 MiB ± 21.3 MiB -0.25 %
10000_development-mode_hmr + rss memory 1906 MiB ± 321 MiB 1909 MiB ± 292 MiB +0.14 %
10000_production-mode + rss memory 699 MiB ± 38.9 MiB 729 MiB ± 32.7 MiB +4.31 %
arco-pro_development-mode + rss memory 732 MiB ± 47.1 MiB 695 MiB ± 30.9 MiB -5.12 %
arco-pro_development-mode_hmr + rss memory 825 MiB ± 19.7 MiB 797 MiB ± 68.1 MiB -3.47 %
arco-pro_production-mode + rss memory 792 MiB ± 69.8 MiB 821 MiB ± 61.3 MiB +3.61 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 815 MiB ± 54.2 MiB 838 MiB ± 50.6 MiB +2.82 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 841 MiB ± 32.3 MiB 829 MiB ± 37.2 MiB -1.46 %
threejs_development-mode_10x + rss memory 782 MiB ± 63.4 MiB 742 MiB ± 37.6 MiB -5.04 %
threejs_development-mode_10x_hmr + rss memory 1686 MiB ± 334 MiB 1630 MiB ± 251 MiB -3.34 %
threejs_production-mode_10x + rss memory 1103 MiB ± 83.2 MiB 1129 MiB ± 114 MiB +2.36 %

Please sign in to comment.