fix: avoid double react refresh transform in rspack-dev-server (#4243)

fix: double react refresh transform
web-infra-dev · Sep 25, 2023 · 95d63b4 · 95d63b4
1 parent a757197
commit 95d63b4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/rspack-dev-server/src/server.ts b/packages/rspack-dev-server/src/server.ts
@@ -166,7 +166,21 @@ export class RspackDevServer extends WebpackDevServer {
 					// enable react.refresh by default
 					compiler.options.builtins.react.refresh ??= true;
 					if (compiler.options.builtins.react.refresh) {
-						new ReactRefreshPlugin().apply(compiler);
+						const runtimePaths = ReactRefreshPlugin.deprecated_runtimePaths;
+						new compiler.webpack.EntryPlugin(
+							compiler.context,
+							runtimePaths[0],
+							{
+								name: undefined
+							}
+						).apply(compiler);
+						new compiler.webpack.ProvidePlugin({
+							$ReactRefreshRuntime$: runtimePaths[1]
+						}).apply(compiler);
+						compiler.options.module.rules.unshift({
+							include: runtimePaths,
+							type: "js"
+						});
 					}
 				}
 			} else if (compiler.options.builtins.react.refresh) {

diff --git a/packages/rspack-plugin-react-refresh/src/index.js b/packages/rspack-plugin-react-refresh/src/index.js
@@ -18,9 +18,9 @@ const refreshRuntimeDirPath = path.dirname(
 	})
 );
 const runtimePaths = [
+	reactRefreshEntryPath,
 	reactRefreshPath,
 	refreshUtilsPath,
-	reactRefreshEntryPath,
 	refreshRuntimeDirPath
 ];
 
@@ -61,3 +61,5 @@ module.exports = class ReactRefreshRspackPlugin {
 		});
 	}
 };
+
+module.exports.deprecated_runtimePaths = runtimePaths;