fix: filter export imported specifier used name . (#4229)

* chore: 🤖 init * chore: 🤖 add false positive list * chore: 🤖 add case * chore: 🤖 export imported should filter the id list * chore: 🤖 update snapshot * chore: 🤖 lint
web-infra-dev · Sep 21, 2023 · 9272b8a · 9272b8a
1 parent d6072e5
commit 9272b8a
Show file tree

Hide file tree

Showing 29 changed files with 77 additions and 126 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -169,4 +169,4 @@ jobs:
           echo 'debug = false' >> Cargo.toml
 
       - name: Run test
-        run: IS_NEW_TREESHAKING=1 cargo test --workspace -- --nocapture
+        run: cargo test --workspace -- --nocapture
diff --git a/crates/rspack/tests/check.js b/crates/rspack/tests/check.js
@@ -19,11 +19,17 @@ const filteredList = dirList.filter((dir) => {
 
 console.log(`total: ${filteredList.length}`)
 
+const falsePositiveList = [
+	'cjs-export-computed-property', // This one is false positive because webpack will not counted a esm export as unsed in an entry module, the previous implementation follows the esbuild behavior , see https://gist.github.com/IWANABETHATGUY/b41d0f80a558580010276a44b310a473
+]
 const failedList = filteredList.filter(item => {
+	if (falsePositiveList.includes(item)) {
+		return false;
+	}
 	const abPath = path.join(currentDir, item, "snapshot", "snap.diff")
 	return fs.existsSync(abPath)
 })
 
 console.log(`failed: ${failedList.length}`)
 console.log(`passed: ${filteredList.length - failedList.length}`)
-console.log(failedList)
+console.log('failed list:\n', failedList)
diff --git a/crates/rspack/tests/fixtures.rs b/crates/rspack/tests/fixtures.rs
@@ -23,10 +23,9 @@ fn samples(fixture_path: PathBuf) {
 
 #[fixture("tests/tree-shaking/*", exclude("node_modules"))]
 fn tree_shaking(fixture_path: PathBuf) {
-  std::env::set_var("IS_NEW_TREESHAKING", "1");
   // For each test case
   // First test is old version tree shaking snapshot test
-  test_fixture(&fixture_path, Box::new(|_, _| {}), None);
+  // test_fixture(&fixture_path, Box::new(|_, _| {}), None);
   // second test is webpack based tree shaking
   IS_NEW_TREESHAKING.store(true, Ordering::SeqCst);
   test_fixture(

diff --git a/crates/rspack/tests/tree-shaking/bb/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/bb/snapshot/new_treeshaking.snap
@@ -6,9 +6,6 @@ source: crates/rspack_testing/src/run_fixture.rs
 "./a.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 'use strict';
 __webpack_require__.r(__webpack_exports__);
-__webpack_require__.d(__webpack_exports__, {
-  'c': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_.c; }
-});
 /* harmony import */var _c_js__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./c.js */"./c.js");
 __webpack_require__.es(_c_js__WEBPACK_IMPORTED_MODULE_1_, __webpack_exports__);
 /* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./b.js */"./b.js");

diff --git a/crates/rspack/tests/tree-shaking/bb/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/bb/snapshot/snap.diff
@@ -1,13 +1,10 @@
 --- expected
 +++ actual
-@@ -6,9 +6,12 @@
+@@ -6,9 +6,9 @@
  "./a.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);
 -/* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./b.js */"./b.js");
-+__webpack_require__.d(__webpack_exports__, {
-+  'c': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_.c; }
-+});
  /* harmony import */var _c_js__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./c.js */"./c.js");
  __webpack_require__.es(_c_js__WEBPACK_IMPORTED_MODULE_1_, __webpack_exports__);
 +/* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./b.js */"./b.js");

diff --git a/crates/rspack/tests/tree-shaking/export_star/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/export_star/snapshot/new_treeshaking.snap
@@ -6,9 +6,6 @@ source: crates/rspack_testing/src/run_fixture.rs
 "./bar.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 'use strict';
 __webpack_require__.r(__webpack_exports__);
-__webpack_require__.d(__webpack_exports__, {
-  'bar': function() { return _foo__WEBPACK_IMPORTED_MODULE_0_; }
-});
 /* harmony import */var _foo__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./foo */"./foo.js");
 /* harmony import */var _result__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./result */"./result.js");
 __webpack_require__.es(_result__WEBPACK_IMPORTED_MODULE_1_, __webpack_exports__);

diff --git a/crates/rspack/tests/tree-shaking/export_star/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/export_star/snapshot/snap.diff
@@ -1,6 +1,16 @@
 --- expected
 +++ actual
-@@ -19,9 +19,6 @@
+@@ -6,9 +6,6 @@
+ "./bar.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
+ 'use strict';
+ __webpack_require__.r(__webpack_exports__);
+-__webpack_require__.d(__webpack_exports__, {
+-  'bar': function() { return _foo__WEBPACK_IMPORTED_MODULE_0_; }
+-});
+ /* harmony import */var _foo__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./foo */"./foo.js");
+ /* harmony import */var _result__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./result */"./result.js");
+ __webpack_require__.es(_result__WEBPACK_IMPORTED_MODULE_1_, __webpack_exports__);
+@@ -19,9 +16,6 @@
  "./foo.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);
@@ -10,7 +20,7 @@
  /* harmony import */var _bar__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./bar */"./bar.js");
  __webpack_require__.es(_bar__WEBPACK_IMPORTED_MODULE_0_, __webpack_exports__);
  /* harmony import */var _result__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./result */"./result.js");
-@@ -42,9 +39,6 @@
+@@ -42,9 +36,6 @@
  "./result.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);

diff --git a/...es/rspack/tests/tree-shaking/import-var-assign-side-effects/snapshot/new_treeshaking.snap b/...es/rspack/tests/tree-shaking/import-var-assign-side-effects/snapshot/new_treeshaking.snap
@@ -18,7 +18,6 @@ class Something {
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'Layout': function() { return _layout_export__WEBPACK_IMPORTED_MODULE_0_["default"]; },
   'Sider': function() { return _Something__WEBPACK_IMPORTED_MODULE_1_["default"]; }
 });
 /* harmony import */var _layout_export__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./layout_export */"./layout_export.js");

diff --git a/crates/rspack/tests/tree-shaking/import-var-assign-side-effects/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/import-var-assign-side-effects/snapshot/snap.diff
@@ -18,18 +18,15 @@
  class Something {
  }
  },
-@@ -16,8 +18,10 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
+@@ -18,6 +20,7 @@
  __webpack_require__.d(__webpack_exports__, {
-+  'Layout': function() { return _layout_export__WEBPACK_IMPORTED_MODULE_0_["default"]; },
    'Sider': function() { return _Something__WEBPACK_IMPORTED_MODULE_1_["default"]; }
  });
 +/* harmony import */var _layout_export__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./layout_export */"./layout_export.js");
  /* harmony import */var _Something__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./Something */"./Something.js");
 
 
-@@ -30,6 +34,17 @@
+@@ -30,6 +33,17 @@
 
  (0, _export__WEBPACK_IMPORTED_MODULE_0_.Sider)();
  },

diff --git a/crates/rspack/tests/tree-shaking/prune-bailout-module/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/prune-bailout-module/snapshot/new_treeshaking.snap
@@ -31,8 +31,7 @@ _lib__WEBPACK_IMPORTED_MODULE_0_.a;
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'a': function() { return _a_js__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-  'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+  'a': function() { return _a_js__WEBPACK_IMPORTED_MODULE_0_["default"]; }
 });
 /* harmony import */var _a_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./a.js */"./a.js");
 /* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./b.js */"./b.js");

diff --git a/crates/rspack/tests/tree-shaking/prune-bailout-module/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/prune-bailout-module/snapshot/snap.diff
@@ -24,13 +24,8 @@
  "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);
-@@ -22,9 +31,11 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
--  'a': function() { return _a_js__WEBPACK_IMPORTED_MODULE_0_["default"]; }
-+  'a': function() { return _a_js__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-+  'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+@@ -25,6 +34,7 @@
+   'a': function() { return _a_js__WEBPACK_IMPORTED_MODULE_0_["default"]; }
  });
  /* harmony import */var _a_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./a.js */"./a.js");
 +/* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./b.js */"./b.js");

diff --git a/crates/rspack/tests/tree-shaking/reexport_entry_elimination/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/reexport_entry_elimination/snapshot/new_treeshaking.snap
@@ -7,8 +7,7 @@ source: crates/rspack_testing/src/run_fixture.rs
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-  'c': function() { return _c_js__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+  'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_["default"]; }
 });
 /* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./b.js */"./b.js");
 /* harmony import */var _c_js__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./c.js */"./c.js");

diff --git a/crates/rspack/tests/tree-shaking/reexport_entry_elimination/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/reexport_entry_elimination/snapshot/snap.diff
@@ -1,12 +1,7 @@
 --- expected
 +++ actual
-@@ -7,18 +7,17 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
--  'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_["default"]; }
-+  'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-+  'c': function() { return _c_js__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+@@ -10,15 +10,13 @@
+   'b': function() { return _b_js__WEBPACK_IMPORTED_MODULE_0_["default"]; }
  });
  /* harmony import */var _b_js__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./b.js */"./b.js");
 +/* harmony import */var _c_js__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./c.js */"./c.js");

diff --git a/crates/rspack/tests/tree-shaking/rename-export-from-import/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/rename-export-from-import/snapshot/new_treeshaking.snap
@@ -7,7 +7,6 @@ source: crates/rspack_testing/src/run_fixture.rs
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'a': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_.answer; },
   'q': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_.question; }
 });
 /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");

diff --git a/crates/rspack/tests/tree-shaking/rename-export-from-import/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/rename-export-from-import/snapshot/snap.diff
@@ -1,14 +1,6 @@
 --- expected
 +++ actual
-@@ -7,6 +7,7 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
-+  'a': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_.answer; },
-   'q': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_.question; }
- });
- /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
-@@ -23,9 +24,6 @@
+@@ -23,9 +23,6 @@
  "./lib.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);

diff --git a/crates/rspack/tests/tree-shaking/side-effects-analyzed/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/side-effects-analyzed/snapshot/new_treeshaking.snap
@@ -7,8 +7,7 @@ source: crates/rspack_testing/src/run_fixture.rs
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-  'b': function() { return _src_a__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
 });
 /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
 /* harmony import */var _src_a__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./src/a */"./src/a.js");

diff --git a/crates/rspack/tests/tree-shaking/side-effects-analyzed/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/side-effects-analyzed/snapshot/snap.diff
@@ -1,19 +1,14 @@
 --- expected
 +++ actual
-@@ -7,9 +7,11 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
--  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
-+  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-+  'b': function() { return _src_a__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+@@ -10,6 +10,7 @@
+   'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
  });
  /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
 +/* harmony import */var _src_a__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./src/a */"./src/a.js");
 
 
  },
-@@ -24,13 +26,20 @@
+@@ -24,13 +25,20 @@
  'use strict';
  __webpack_require__.r(__webpack_exports__);
  __webpack_require__.d(__webpack_exports__, {

diff --git a/crates/rspack/tests/tree-shaking/side-effects-flagged-only/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/side-effects-flagged-only/snapshot/new_treeshaking.snap
@@ -7,8 +7,7 @@ source: crates/rspack_testing/src/run_fixture.rs
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-  'b': function() { return _src_a__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
 });
 /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
 /* harmony import */var _src_a__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./src/a */"./src/a.js");

diff --git a/crates/rspack/tests/tree-shaking/side-effects-flagged-only/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/side-effects-flagged-only/snapshot/snap.diff
@@ -1,16 +1,6 @@
 --- expected
 +++ actual
-@@ -7,7 +7,8 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
--  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
-+  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-+  'b': function() { return _src_a__WEBPACK_IMPORTED_MODULE_1_["default"]; }
- });
- /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
- /* harmony import */var _src_a__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./src/a */"./src/a.js");
-@@ -25,7 +26,7 @@
+@@ -25,7 +25,7 @@
  'use strict';
  __webpack_require__.r(__webpack_exports__);
  __webpack_require__.d(__webpack_exports__, {

diff --git a/crates/rspack/tests/tree-shaking/side-effects-two/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/side-effects-two/snapshot/new_treeshaking.snap
@@ -7,8 +7,7 @@ source: crates/rspack_testing/src/run_fixture.rs
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-  'b': function() { return _src_a__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
 });
 /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
 /* harmony import */var _src_a__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./src/a */"./src/a.js");

diff --git a/crates/rspack/tests/tree-shaking/side-effects-two/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/side-effects-two/snapshot/snap.diff
@@ -1,19 +1,14 @@
 --- expected
 +++ actual
-@@ -7,9 +7,11 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
--  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
-+  'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; },
-+  'b': function() { return _src_a__WEBPACK_IMPORTED_MODULE_1_["default"]; }
+@@ -10,6 +10,7 @@
+   'something': function() { return _lib__WEBPACK_IMPORTED_MODULE_0_["default"]; }
  });
  /* harmony import */var _lib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* ./lib */"./lib.js");
 +/* harmony import */var _src_a__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* ./src/a */"./src/a.js");
 
   // export {
   //   result as test
-@@ -26,13 +28,20 @@
+@@ -26,13 +27,20 @@
  'use strict';
  __webpack_require__.r(__webpack_exports__);
  __webpack_require__.d(__webpack_exports__, {

diff --git a/crates/rspack/tests/tree-shaking/ts-target-es5/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/ts-target-es5/snapshot/new_treeshaking.snap
@@ -41,8 +41,7 @@ function asyncGeneratorStep(gen, resolve, reject, _next, _throw, key, arg) {
 'use strict';
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
-  '_': function() { return tslib__WEBPACK_IMPORTED_MODULE_0_.__generator; },
-  '_ts_generator': function() { return tslib__WEBPACK_IMPORTED_MODULE_0_.__generator; }
+  '_': function() { return tslib__WEBPACK_IMPORTED_MODULE_0_.__generator; }
 });
 /* harmony import */var tslib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* tslib */"../../../../../node_modules/tslib/tslib.es6.js");
 

diff --git a/crates/rspack/tests/tree-shaking/ts-target-es5/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/ts-target-es5/snapshot/snap.diff
@@ -1,16 +1,6 @@
 --- expected
 +++ actual
-@@ -41,7 +41,8 @@
- 'use strict';
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
--  '_': function() { return tslib__WEBPACK_IMPORTED_MODULE_0_.__generator; }
-+  '_': function() { return tslib__WEBPACK_IMPORTED_MODULE_0_.__generator; },
-+  '_ts_generator': function() { return tslib__WEBPACK_IMPORTED_MODULE_0_.__generator; }
- });
- /* harmony import */var tslib__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* tslib */"../../../../../node_modules/tslib/tslib.es6.js");
-
-@@ -49,9 +50,6 @@
+@@ -49,9 +49,6 @@
  "../../../../../node_modules/tslib/tslib.es6.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);
@@ -20,7 +10,7 @@
  /******************************************************************************
  Copyright (c) Microsoft Corporation.
 
-@@ -482,9 +480,6 @@
+@@ -482,9 +479,6 @@
  "./index.ts": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);

diff --git a/crates/rspack/tests/tree-shaking/webpack-side-effects-all-used/snapshot/new_treeshaking.snap b/crates/rspack/tests/tree-shaking/webpack-side-effects-all-used/snapshot/new_treeshaking.snap
@@ -50,7 +50,6 @@ var z = "z";
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
   'x': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.x; },
-  'y': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.y; },
   'z': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.z; },
   'default': function() { return __WEBPACK_DEFAULT_EXPORT__; }
 });

diff --git a/crates/rspack/tests/tree-shaking/webpack-side-effects-all-used/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/webpack-side-effects-all-used/snapshot/snap.diff
@@ -1,20 +1,12 @@
 --- expected
 +++ actual
-@@ -50,6 +50,7 @@
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
-   'x': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.x; },
-+  'y': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.y; },
-   'z': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.z; },
-   'default': function() { return __WEBPACK_DEFAULT_EXPORT__; }
- });
-@@ -82,8 +83,8 @@
+@@ -82,8 +82,8 @@
  "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);
--/* harmony import */var pmodule_tracker__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* pmodule/tracker */"../node_modules/pmodule/tracker.js");
- /* harmony import */var pmodule__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* pmodule */"../node_modules/pmodule/index.js");
-+/* harmony import */var pmodule_tracker__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* pmodule/tracker */"../node_modules/pmodule/tracker.js");
++/* harmony import */var pmodule__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* pmodule */"../node_modules/pmodule/index.js");
+ /* harmony import */var pmodule_tracker__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* pmodule/tracker */"../node_modules/pmodule/tracker.js");
+-/* harmony import */var pmodule__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* pmodule */"../node_modules/pmodule/index.js");
 
 
 
diff --git a/...spack/tests/tree-shaking/webpack-side-effects-simple-unused/snapshot/new_treeshaking.snap b/...spack/tests/tree-shaking/webpack-side-effects-simple-unused/snapshot/new_treeshaking.snap
@@ -36,7 +36,6 @@ var z = "z";
 __webpack_require__.r(__webpack_exports__);
 __webpack_require__.d(__webpack_exports__, {
   'x': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.x; },
-  'y': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.y; },
   'z': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.z; },
   'default': function() { return __WEBPACK_DEFAULT_EXPORT__; }
 });

diff --git a/crates/rspack/tests/tree-shaking/webpack-side-effects-simple-unused/snapshot/snap.diff b/crates/rspack/tests/tree-shaking/webpack-side-effects-simple-unused/snapshot/snap.diff
@@ -1,20 +1,12 @@
 --- expected
 +++ actual
-@@ -36,6 +36,7 @@
- __webpack_require__.r(__webpack_exports__);
- __webpack_require__.d(__webpack_exports__, {
-   'x': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.x; },
-+  'y': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.y; },
-   'z': function() { return _b__WEBPACK_IMPORTED_MODULE_1_.z; },
-   'default': function() { return __WEBPACK_DEFAULT_EXPORT__; }
- });
-@@ -66,8 +67,8 @@
+@@ -66,8 +66,8 @@
  "./index.js": function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
  'use strict';
  __webpack_require__.r(__webpack_exports__);
--/* harmony import */var pmodule_tracker__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* pmodule/tracker */"../node_modules/pmodule/tracker.js");
- /* harmony import */var pmodule__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* pmodule */"../node_modules/pmodule/index.js");
-+/* harmony import */var pmodule_tracker__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* pmodule/tracker */"../node_modules/pmodule/tracker.js");
++/* harmony import */var pmodule__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* pmodule */"../node_modules/pmodule/index.js");
+ /* harmony import */var pmodule_tracker__WEBPACK_IMPORTED_MODULE_0_ = __webpack_require__(/* pmodule/tracker */"../node_modules/pmodule/tracker.js");
+-/* harmony import */var pmodule__WEBPACK_IMPORTED_MODULE_1_ = __webpack_require__(/* pmodule */"../node_modules/pmodule/index.js");