fix: zod-validation-error type error (#4763)

web-infra-dev · Nov 23, 2023 · 8b0915d · 8b0915d
1 parent 27a160a
commit 8b0915d
Show file tree

Hide file tree

Showing 14 changed files with 75 additions and 136 deletions.
diff --git a/diffcases/arco-pro/tsconfig.json b/diffcases/arco-pro/tsconfig.json
@@ -8,8 +8,6 @@
       "esnext"
     ],
     "allowJs": true,
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "strict": false,

diff --git a/examples/arco-pro/tsconfig.json b/examples/arco-pro/tsconfig.json
@@ -8,8 +8,6 @@
       "esnext"
     ],
     "allowJs": true,
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "strict": false,

diff --git a/examples/basic-ts/tsconfig.json b/examples/basic-ts/tsconfig.json
@@ -10,6 +10,5 @@
     "esModuleInterop": true /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */,
     "forceConsistentCasingInFileNames": true /* Ensure that casing is correct in imports. */,
     "strict": true /* Enable all strict type-checking options. */,
-    "skipLibCheck": true /* Skip type checking all .d.ts files. */
   }
 }
diff --git a/examples/react-storybook/tsconfig.json b/examples/react-storybook/tsconfig.json
@@ -2,8 +2,6 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "strict": true,
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "jsx": "react-jsx",
     "moduleResolution": "node"
   },

diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
     "@rspack/cli": "workspace:*",
     "@taplo/cli": "^0.5.2",
     "@types/jest": "29.1.0",
-    "@types/node": "16",
+    "@types/node": "^20.9.4",
     "@types/rimraf": "3.0.2",
     "commander": "10.0.1",
     "cross-env": "^7.0.3",

diff --git a/packages/create-rspack/template-react-ts/tsconfig.json b/packages/create-rspack/template-react-ts/tsconfig.json
@@ -3,8 +3,6 @@
     "target": "ES6",
     "lib": ["DOM", "DOM.Iterable", "ESNext"],
     "module": "ESNext",
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "moduleResolution": "bundler",
     "allowImportingTsExtensions": true,
     "resolveJsonModule": true,

diff --git a/packages/rspack-plugin-html/tsconfig.json b/packages/rspack-plugin-html/tsconfig.json
@@ -5,8 +5,6 @@
     // related issue: https://github.com/nodejs/node/issues/35889
     "module": "CommonJS",
     "moduleResolution": "Node10",
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   },

diff --git a/packages/rspack-plugin-react-refresh/tsconfig.json b/packages/rspack-plugin-react-refresh/tsconfig.json
@@ -1,8 +1,6 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   },

diff --git a/packages/rspack-test-tools/tsconfig.json b/packages/rspack-test-tools/tsconfig.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   },

diff --git a/packages/rspack/package.json b/packages/rspack/package.json
@@ -81,6 +81,6 @@
     "watchpack": "^2.4.0",
     "webpack-sources": "3.2.3",
     "zod": "^3.21.4",
-    "zod-validation-error": "1.2.0"
+    "zod-validation-error": "1.3.1"
   }
 }
diff --git a/packages/rspack/tsconfig.json b/packages/rspack/tsconfig.json
@@ -1,8 +1,6 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   },