Skip to content

Commit

Permalink
ci: should skip trim paths for doc changes (#8750)
Browse files Browse the repository at this point in the history
  • Loading branch information
@chenjiahan
chenjiahan authored Dec 17, 2024
1 parent 75f0d20 commit 8a7084e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/reusable-build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ jobs:
echo 'incremental = false' >> Cargo.toml
- name: Trim paths
if: ${{ !inputs.skipable }}
shell: bash
run: |
echo $'\n' >> .cargo/config.toml
Expand Down

2 comments on commit 8a7084e

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-12-17 fb2869d) Current Change
10000_big_production-mode_disable-minimize + exec 37.9 s ± 622 ms 38.1 s ± 438 ms +0.61 %
10000_development-mode + exec 1.87 s ± 24 ms 1.82 s ± 29 ms -2.85 %
10000_development-mode_hmr + exec 687 ms ± 28 ms 677 ms ± 30 ms -1.49 %
10000_production-mode + exec 2.47 s ± 48 ms 2.38 s ± 62 ms -3.46 %
arco-pro_development-mode + exec 1.77 s ± 90 ms 1.75 s ± 81 ms -1.07 %
arco-pro_development-mode_hmr + exec 379 ms ± 1.6 ms 378 ms ± 1.2 ms -0.33 %
arco-pro_production-mode + exec 3.31 s ± 75 ms 3.23 s ± 86 ms -2.46 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 152 ms 3.33 s ± 124 ms -1.25 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.34 s ± 124 ms 3.26 s ± 82 ms -2.47 %
threejs_development-mode_10x + exec 1.61 s ± 20 ms 1.63 s ± 15 ms +1.60 %
threejs_development-mode_10x_hmr + exec 794 ms ± 28 ms 809 ms ± 5.9 ms +1.95 %
threejs_production-mode_10x + exec 5.42 s ± 141 ms 5.36 s ± 124 ms -1.04 %
10000_big_production-mode_disable-minimize + rss memory 9482 MiB ± 276 MiB 9495 MiB ± 140 MiB +0.14 %
10000_development-mode + rss memory 633 MiB ± 14.8 MiB 705 MiB ± 20.2 MiB +11.29 %
10000_development-mode_hmr + rss memory 1396 MiB ± 296 MiB 1537 MiB ± 403 MiB +10.06 %
10000_production-mode + rss memory 601 MiB ± 31.9 MiB 707 MiB ± 42.2 MiB +17.71 %
arco-pro_development-mode + rss memory 587 MiB ± 40.3 MiB 640 MiB ± 45.9 MiB +8.91 %
arco-pro_development-mode_hmr + rss memory 639 MiB ± 102 MiB 637 MiB ± 85 MiB -0.35 %
arco-pro_production-mode + rss memory 742 MiB ± 50.5 MiB 763 MiB ± 28.6 MiB +2.79 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 737 MiB ± 45.5 MiB 774 MiB ± 38.2 MiB +5.01 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 720 MiB ± 58.3 MiB 754 MiB ± 55.5 MiB +4.70 %
threejs_development-mode_10x + rss memory 638 MiB ± 22.2 MiB 696 MiB ± 48.4 MiB +9.19 %
threejs_development-mode_10x_hmr + rss memory 1194 MiB ± 248 MiB 1235 MiB ± 332 MiB +3.42 %
threejs_production-mode_10x + rss memory 948 MiB ± 55 MiB 957 MiB ± 60.3 MiB +0.96 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
rsdoctor ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ❌ failure
devserver ✅ success
nuxt ✅ success

Please sign in to comment.