add constructor name for concatenated module

web-infra-dev · Jan 4, 2025 · 7cfe00c · 7cfe00c
1 parent 0de9320
commit 7cfe00c
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 0 deletions.
diff --git a/crates/node_binding/binding.d.ts b/crates/node_binding/binding.d.ts
@@ -219,6 +219,7 @@ export declare class JsExportsInfo {
 }
 
 export declare class JsModule {
+  get constructorName(): string
   get context(): string | undefined
   get originalSource(): JsCompatSource | undefined
   get resource(): string | undefined

diff --git a/crates/rspack_binding_values/src/module.rs b/crates/rspack_binding_values/src/module.rs
@@ -68,6 +68,13 @@ impl JsModule {
 
 #[napi]
 impl JsModule {
+  #[napi(getter)]
+  pub fn constructor_name(&mut self) -> napi::Result<String> {
+    let module = self.as_ref()?;
+
+    Ok(module.constructor_name().to_string())
+  }
+
   #[napi(getter)]
   pub fn context(&mut self) -> napi::Result<Either<String, ()>> {
     let module = self.as_ref()?;

diff --git a/crates/rspack_core/src/concatenated_module.rs b/crates/rspack_core/src/concatenated_module.rs
@@ -472,6 +472,10 @@ impl DependenciesBlock for ConcatenatedModule {
 #[cacheable_dyn]
 #[async_trait::async_trait]
 impl Module for ConcatenatedModule {
+  fn constructor_name(&self) -> &'static str {
+    "ConcatenatedModule"
+  }
+
   fn module_type(&self) -> &ModuleType {
     // https://github.com/webpack/webpack/blob/1f99ad6367f2b8a6ef17cce0e058f7a67fb7db18/lib/optimize/ConcatenatedModule.js#L688
     &ModuleType::JsEsm

diff --git a/crates/rspack_core/src/module.rs b/crates/rspack_core/src/module.rs
@@ -210,6 +210,10 @@ pub trait Module:
   + Diagnosable
   + ModuleSourceMapConfig
 {
+  fn constructor_name(&self) -> &'static str {
+    "Module"
+  }
+
   /// Defines what kind of module this is.
   fn module_type(&self) -> &ModuleType;
 

diff --git a/packages/rspack/src/Module.ts b/packages/rspack/src/Module.ts
@@ -261,6 +261,12 @@ export class Module {
 		}
 
 		Object.defineProperties(this, {
+			constructorName: {
+				enumerable: true,
+				get(): string {
+					return module.constructorName;
+				}
+			},
 			type: {
 				enumerable: true,
 				get(): string | null {