Skip to content

Commit

Permalink
fix(dev-server): pin webpack-dev-server version (#7784)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hardfist
hardfist authored Sep 4, 2024
1 parent 56af749 commit 7197fa0
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 34 deletions.
2 changes: 1 addition & 1 deletion packages/playground/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"vue": "^3.4.21",
"vue-loader": "^17.3.1",
"css-loader": "^6.11.0",
"webpack-dev-server": "^5.0.4",
"webpack-dev-server": "5.0.4",
"ws": "^8.16.0"
}
}
2 changes: 1 addition & 1 deletion packages/rspack-dev-server/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"http-proxy-middleware": "^2.0.6",
"mime-types": "^2.1.35",
"webpack-dev-middleware": "^7.4.2",
"webpack-dev-server": "^5.0.4",
"webpack-dev-server": "5.0.4",
"ws": "^8.16.0"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/rspack/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"tsc-alias": "^1.8.8",
"typescript": "5.0.2",
"watchpack": "^2.4.0",
"webpack-dev-server": "^5.0.4",
"webpack-dev-server": "5.0.4",
"webpack-sources": "3.2.3",
"zod": "^3.23.8",
"zod-validation-error": "3.3.1"
Expand Down
40 changes: 10 additions & 30 deletions pnpm-lock.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/webpack-test/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"util": "0.12.5",
"uvu": "0.5.6",
"webassembly-feature": "^1.3.0",
"webpack-dev-server": "^5.0.4"
"webpack-dev-server": "5.0.4"
},
"dependencies": {
"@rspack/binding": "workspace:*",
Expand Down

2 comments on commit 7197fa0

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-09-04 cd962e5) Current Change
10000_development-mode + exec 2.22 s ± 25 ms 2.23 s ± 34 ms +0.37 %
10000_development-mode_hmr + exec 683 ms ± 19 ms 683 ms ± 14 ms +0.07 %
10000_production-mode + exec 2.85 s ± 46 ms 2.84 s ± 32 ms -0.44 %
arco-pro_development-mode + exec 1.83 s ± 75 ms 1.82 s ± 73 ms -0.50 %
arco-pro_development-mode_hmr + exec 435 ms ± 1.7 ms 433 ms ± 2.9 ms -0.51 %
arco-pro_production-mode + exec 3.24 s ± 78 ms 3.24 s ± 80 ms -0.06 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 63 ms 3.33 s ± 69 ms +0.56 %
threejs_development-mode_10x + exec 1.66 s ± 15 ms 1.66 s ± 26 ms +0.05 %
threejs_development-mode_10x_hmr + exec 803 ms ± 14 ms 796 ms ± 2.1 ms -0.92 %
threejs_production-mode_10x + exec 5.15 s ± 29 ms 5.15 s ± 41 ms -0.04 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success

Please sign in to comment.