fix: passing option as &str caused memory leak in `builtin:swc-load…

…er` (#4235) fix: use `String` instead of `&str`
web-infra-dev · Sep 25, 2023 · 591f55d · 591f55d
1 parent f816657
commit 591f55d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/crates/node_binding/src/loader.rs b/crates/node_binding/src/loader.rs
@@ -6,8 +6,8 @@ use rspack_binding_options::{run_builtin_loader as run_builtin, JsLoaderContext}
 #[allow(unused)]
 pub async fn run_builtin_loader(
   builtin: String,
-  options: Option<&str>,
+  options: Option<String>,
   loader_context: JsLoaderContext,
 ) -> Result<JsLoaderContext> {
-  run_builtin(builtin, options, loader_context).await
+  run_builtin(builtin, options.as_deref(), loader_context).await
 }