chore(infra/biome): enable noParameterAssign

web-infra-dev · Aug 3, 2024 · 58ee67a · 58ee67a
1 parent 4e666c2
commit 58ee67a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -47,7 +47,6 @@
 				"noVoidTypeReturn": "off"
 			},
 			"style": {
-				"noParameterAssign": "off",
 				"noNonNullAssertion": "off"
 			},
 			"performance": {
@@ -88,4 +87,4 @@
 		"clientKind": "git",
 		"useIgnoreFile": true
 	}
-}
+}
diff --git a/packages/rspack-lite-tapable/src/index.ts b/packages/rspack-lite-tapable/src/index.ts
@@ -122,15 +122,9 @@ export class HookBase<T, R, AdditionalOptions = UnsetAdditionalOptions>
 	_runRegisterInterceptors(
 		options: FullTap & IfSet<AdditionalOptions>
 	): FullTap & IfSet<AdditionalOptions> {
-		for (const interceptor of this.interceptors) {
-			if (interceptor.register) {
-				const newOptions = interceptor.register(options);
-				if (newOptions !== undefined) {
-					options = newOptions;
-				}
-			}
-		}
-		return options;
+		return this.interceptors.reduce((options, interceptor) => {
+			return interceptor.register?.(options) || options;
+		}, options);
 	}
 
 	_runCallInterceptors(...args: any[]) {