Skip to content

Commit

Permalink
perf: remove tokio-console to reduce binary size (#8681)
Browse files Browse the repository at this point in the history
  • Loading branch information
@chenjiahan
chenjiahan authored Dec 12, 2024
1 parent d1079dc commit 366a761
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 429 deletions.
1 change: 0 additions & 1 deletion .cargo/config.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ rustflags = [
# "-Wclippy::same_name_method",

"-Aclippy::default_constructed_unit_structs",
"--cfg", "tokio_unstable"
]

# Fix napi breaking in test environment <https://github.com/napi-rs/napi-rs/issues/1005#issuecomment-1011034770>
Expand Down
Loading

2 comments on commit 366a761

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
rsdoctor ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success
nuxt ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-12-12 bd04c60) Current Change
10000_big_production-mode_disable-minimize + exec 37.6 s ± 508 ms 37.7 s ± 450 ms +0.30 %
10000_development-mode + exec 1.81 s ± 43 ms 1.78 s ± 28 ms -1.20 %
10000_development-mode_hmr + exec 664 ms ± 20 ms 641 ms ± 9.1 ms -3.53 %
10000_production-mode + exec 2.36 s ± 57 ms 2.33 s ± 37 ms -1.63 %
arco-pro_development-mode + exec 1.78 s ± 81 ms 1.77 s ± 66 ms -0.17 %
arco-pro_development-mode_hmr + exec 426 ms ± 9.5 ms 378 ms ± 1.6 ms -11.20 %
arco-pro_production-mode + exec 3.17 s ± 81 ms 3.08 s ± 79 ms -2.63 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.16 s ± 62 ms 3.16 s ± 73 ms -0.16 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.17 s ± 74 ms 3.1 s ± 66 ms -2.37 %
threejs_development-mode_10x + exec 1.62 s ± 15 ms 1.59 s ± 19 ms -1.56 %
threejs_development-mode_10x_hmr + exec 807 ms ± 23 ms 777 ms ± 11 ms -3.66 %
threejs_production-mode_10x + exec 5.17 s ± 112 ms 4.85 s ± 76 ms -6.21 %
10000_big_production-mode_disable-minimize + rss memory 9583 MiB ± 89.8 MiB 9840 MiB ± 125 MiB +2.69 %
10000_development-mode + rss memory 794 MiB ± 14.3 MiB 818 MiB ± 38.8 MiB +3.03 %
10000_development-mode_hmr + rss memory 1821 MiB ± 230 MiB 2079 MiB ± 142 MiB +14.15 %
10000_production-mode + rss memory 690 MiB ± 41 MiB 708 MiB ± 41.1 MiB +2.58 %
arco-pro_development-mode + rss memory 704 MiB ± 24.9 MiB 711 MiB ± 31.9 MiB +0.95 %
arco-pro_development-mode_hmr + rss memory 916 MiB ± 59.6 MiB 808 MiB ± 80.3 MiB -11.75 %
arco-pro_production-mode + rss memory 806 MiB ± 38.3 MiB 821 MiB ± 43.7 MiB +1.81 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 808 MiB ± 46 MiB 828 MiB ± 71.3 MiB +2.45 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 801 MiB ± 43.9 MiB 835 MiB ± 50.6 MiB +4.16 %
threejs_development-mode_10x + rss memory 769 MiB ± 37.9 MiB 773 MiB ± 72.3 MiB +0.57 %
threejs_development-mode_10x_hmr + rss memory 1548 MiB ± 311 MiB 1677 MiB ± 299 MiB +8.38 %
threejs_production-mode_10x + rss memory 1095 MiB ± 61.1 MiB 1115 MiB ± 76.8 MiB +1.86 %

Please sign in to comment.