chore(infra/biome): enable noEmptyPattern (#7384)

* chore(infra/biome): enable noEmptyPattern * chore: fix @playwright/test error
web-infra-dev · Jul 31, 2024 · 2f6696e · 2f6696e · rspack-bot · Jul 31, 2024
1 parent 632ad0a
commit 2f6696e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -48,7 +48,6 @@
 				"noExtraBooleanCast": "off"
 			},
 			"correctness": {
-				"noEmptyPattern": "off",
 				"noConstructorReturn": "off",
 				"noSwitchDeclarations": "off",
 				"noInvalidUseBeforeDeclaration": "off",

diff --git a/packages/playground/fixtures/pathInfo.ts b/packages/playground/fixtures/pathInfo.ts
@@ -39,7 +39,7 @@ async function calcPathInfo(
 }
 
 export const pathInfoFixtures: Fixtures<PathInfoFixtures> = {
-	pathInfo: async ({}, use, { file, workerIndex }) => {
+	pathInfo: async ({ page: _ }: any, use, { file, workerIndex }) => {
 		const pathInfo: PathInfo = await calcPathInfo(file, String(workerIndex));
 		await use(pathInfo);
 		await fs.remove(pathInfo.tempProjectDir);
Name	Base (2024-07-31 9e2cbe9)	Current	Change
10000_development-mode + exec	2.27 s ± 20 ms	2.24 s ± 31 ms	-1.34 %
10000_development-mode_hmr + exec	702 ms ± 11 ms	717 ms ± 7.1 ms	+2.26 %
10000_production-mode + exec	2.76 s ± 39 ms	2.8 s ± 35 ms	+1.37 %
arco-pro_development-mode + exec	1.88 s ± 66 ms	1.9 s ± 85 ms	+0.88 %
arco-pro_development-mode_hmr + exec	433 ms ± 1.7 ms	434 ms ± 4.1 ms	+0.40 %
arco-pro_production-mode + exec	3.45 s ± 114 ms	3.43 s ± 80 ms	-0.53 %
threejs_development-mode_10x + exec	1.75 s ± 25 ms	1.76 s ± 27 ms	+0.70 %
threejs_development-mode_10x_hmr + exec	863 ms ± 8.3 ms	877 ms ± 8.6 ms	+1.63 %
threejs_production-mode_10x + exec	5.49 s ± 26 ms	5.49 s ± 41 ms	-0.03 %
suite	result
modernjs	❌ failure
_selftest	✅ success
nx	❌ failure
rspress	✅ success
rsbuild	❌ failure
examples	✅ success