Skip to content

Commit

Permalink
chore(create-rspack): bump Rslib 0.0.12 and adjust dirname (#8124)
Browse files Browse the repository at this point in the history
  • Loading branch information
chenjiahan authored Oct 15, 2024
1 parent a97e105 commit 1229b37
Show file tree
Hide file tree
Showing 4 changed files with 138 additions and 28 deletions.
4 changes: 2 additions & 2 deletions packages/create-rspack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"dev": "rslib build -w"
},
"dependencies": {
"create-rstack": "1.0.2"
"create-rstack": "1.0.6"
},
"devDependencies": {
"@rslib/core": "0.0.5",
"@rslib/core": "0.0.12",
"typescript": "5.0.2"
},
"publishConfig": {
Expand Down
3 changes: 3 additions & 0 deletions packages/create-rspack/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import path from "node:path";
import { fileURLToPath } from "node:url";
import {
type Argv,
type ESLintTemplateName,
Expand All @@ -7,6 +8,8 @@ import {
select
} from "create-rstack";

const __dirname = path.dirname(fileURLToPath(import.meta.url));

async function getTemplateName({ template }: Argv) {
if (typeof template === "string") {
const pair = template.split("-");
Expand Down
1 change: 1 addition & 0 deletions packages/create-rspack/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"src"
],
"compilerOptions": {
"module": "NodeNext",
"outDir": "dist",
"rootDir": "src"
}
Expand Down
158 changes: 132 additions & 26 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 comments on commit 1229b37

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-10-15 25af140) Current Change
10000_development-mode + exec 2.12 s ± 39 ms 2.1 s ± 32 ms -0.70 %
10000_development-mode_hmr + exec 665 ms ± 22 ms 665 ms ± 15 ms +0.05 %
10000_production-mode + exec 2.65 s ± 33 ms 2.62 s ± 32 ms -0.83 %
arco-pro_development-mode + exec 1.82 s ± 87 ms 1.79 s ± 65 ms -1.67 %
arco-pro_development-mode_hmr + exec 426 ms ± 1.9 ms 426 ms ± 1.1 ms +0.10 %
arco-pro_production-mode + exec 3.04 s ± 65 ms 3.06 s ± 59 ms +0.74 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.15 s ± 70 ms 3.12 s ± 73 ms -0.92 %
threejs_development-mode_10x + exec 1.64 s ± 15 ms 1.61 s ± 12 ms -1.49 %
threejs_development-mode_10x_hmr + exec 788 ms ± 11 ms 755 ms ± 8.7 ms -4.24 %
threejs_production-mode_10x + exec 4.97 s ± 28 ms 4.94 s ± 11 ms -0.71 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ❌ failure

Please sign in to comment.