fix: CARGO_INCREMENTAL

web-infra-dev · Dec 23, 2024 · 028a0eb · 028a0eb
1 parent 6ba29bc
commit 028a0eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.github/actions/rustup/action.yml b/.github/actions/rustup/action.yml
@@ -89,4 +89,4 @@ runs:
       if: ${{ startsWith(runner.name, 'GitHub Actions') }}
       with:
         shared-key: ${{ inputs.shared-key }}
-        # save-if: ${{ inputs.save-cache == 'true' }}
+        save-if: ${{ inputs.save-cache == 'true' }}
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,6 +21,11 @@ on:
     tags-ignore:
       - "**"
 
+env:
+  # Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness.
+  # https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11
+  CARGO_INCREMENTAL: 0
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
   cancel-in-progress: ${{ github.ref_name != 'main' }}