feat: parallel call stream_chunks of childern #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyMind
force-pushed
the
try-to-parallel
branch
from
6c30b77 to
5d4a6ab
Compare
CodSpeed Performance ReportMerging #86 will not alter performanceComparing Summary
|
SyMind
force-pushed
the
try-to-parallel
branch
from
137df95 to
f9e1999
Compare
Boshen
reviewed
Feb 1, 2024
src/concat_source.rs
Outdated
| let mut need_to_close_mapping = false; | ||
|
|
||
| let result = self | ||
| .children |
There was a problem hiding this comment.
You should filter out children that just strings or shallow, because spawning thread will out weight the processing.
You should also checkout #72 for concat source because concat source is not optimized for this kind of computation yet.
SyMind
force-pushed
the
try-to-parallel
branch
from
ece4237 to
1e5a3a4
Compare
SyMind
force-pushed
the
try-to-parallel
branch
from
1e5a3a4 to
3382e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.