Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: flatten concat_source when constructing it #78

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Nov 29, 2023

Copy link
Contributor Author

Boshen commented Nov 29, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@Boshen Boshen requested a review from ahabhgk November 29, 2023 09:29
Copy link

codspeed-hq bot commented Nov 29, 2023

CodSpeed Performance Report

Merging #78 will not alter performance

Comparing 11-29-perf_flatten_concat_source_when_constructing_it (bc00dff) with main (8bae04e)

Summary

✅ 4 untouched benchmarks

@Boshen Boshen force-pushed the 11-29-perf_flatten_concat_source_when_constructing_it branch from 9ac6552 to ba992df Compare November 30, 2023 08:12
@Boshen Boshen marked this pull request as draft December 22, 2023 06:46
@Boshen Boshen closed this Jan 19, 2024
@SyMind SyMind reopened this Feb 20, 2024
@SyMind
Copy link
Member

SyMind commented Feb 20, 2024

@ahabhgk This PR guarantees stable hashing when the output from the Source map method yields identical results, despite variations in the sequence of ConcatSource aggregations.

@ahabhgk ahabhgk marked this pull request as ready for review February 20, 2024 05:53
@ahabhgk ahabhgk merged commit eca4132 into main Feb 20, 2024
8 checks passed
@ahabhgk ahabhgk deleted the 11-29-perf_flatten_concat_source_when_constructing_it branch February 20, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants