Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add windows test #61

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Aug 5, 2024

Summary

  1. add windows test yml
  2. add path-serializer as vitest snapshot serializer

@SoonIter SoonIter force-pushed the infra/e2e-helper-2 branch from 4e63c4a to 624a686 Compare August 5, 2024 12:09
@Timeless0911
Copy link
Collaborator

We need path serializer.

@fi3ework
Copy link
Member

fi3ework commented Aug 5, 2024

@SoonIter If you're not in a hurry, I'll resolve web-infra-dev/rsbuild#3099 by tomorrow night at the latest. Or you can claim this task if you have enough spare time.

@SoonIter
Copy link
Member Author

SoonIter commented Aug 5, 2024

@SoonIter If you're not in a hurry, I'll resolve web-infra-dev/rsbuild#3099 by tomorrow night at the latest. Or you can claim this task if you have enough spare time.

you can name the package repo and assign it to me

@fi3ework
Copy link
Member

fi3ework commented Aug 5, 2024

What about https://www.npmjs.com/package/serializer-path or https://www.npmjs.com/package/path-serializer, not claimed and easy to search without any prefix/suffix.

@SoonIter
Copy link
Member Author

SoonIter commented Aug 5, 2024

What about npmjs.com/package/serializer-path or npmjs.com/package/path-serializer, not claimed and easy to search without any prefix/suffix.

path-serializer is better

@SoonIter SoonIter force-pushed the infra/e2e-helper-2 branch from 624a686 to 3f7b451 Compare August 9, 2024 09:47
@SoonIter
Copy link
Member Author

SoonIter commented Aug 9, 2024

done

@SoonIter SoonIter enabled auto-merge (squash) August 9, 2024 11:40
@fi3ework
Copy link
Member

fi3ework commented Aug 9, 2024

Good job! The path-serializer has become the first published package built by Rslib (with help of manual magic).

@SoonIter SoonIter merged commit 38fcca5 into web-infra-dev:main Aug 9, 2024
6 checks passed
@SoonIter SoonIter mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants