Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autoExternal default to false when format is umd or mf #531

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Dec 6, 2024

Summary

Disable autoExternal when format is umd or mf since their outputs will be directly consumed.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 1c2685d
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6756b0c4a51f36000816b06a
😎 Deploy Preview https://deploy-preview-531--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #531 will not alter performance

Comparing feat/disable-auto-external (9a1e8a7) with main (4073e70)

Summary

✅ 5 untouched benchmarks

2heal1
2heal1 previously approved these changes Dec 6, 2024
@Timeless0911 Timeless0911 force-pushed the feat/disable-auto-external branch from b844fe7 to ba55822 Compare December 9, 2024 07:35
@Timeless0911 Timeless0911 changed the title feat: disable autoExternal when format is umd or mf feat: autoExternal default to false when format is umd or mf Dec 9, 2024
@Timeless0911 Timeless0911 enabled auto-merge (squash) December 9, 2024 09:27
@Timeless0911 Timeless0911 merged commit 399c083 into main Dec 9, 2024
19 checks passed
@Timeless0911 Timeless0911 deleted the feat/disable-auto-external branch December 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants