Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rootDir calculation should ignore declaration files #389

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

rootDir calculation should ignore declaration files

see https://www.typescriptlang.org/tsconfig/#rootDir

Related Links

closes: #385

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit e329398
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/672de0db5776240008268214
😎 Deploy Preview https://deploy-preview-389--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #389 will not alter performance

Comparing fix/rootdir (e329398) with main (ce4dea9)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework merged commit 8bee065 into main Nov 8, 2024
21 checks passed
@fi3ework fi3ework deleted the fix/rootdir branch November 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error with dts bundle enabled with multiple tsconfig includes
2 participants