Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: autoExtension unit test #36

Merged
merged 1 commit into from
Jul 15, 2024
Merged

test: autoExtension unit test #36

merged 1 commit into from
Jul 15, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from fi3ework July 15, 2024 06:27
@fi3ework
Copy link
Member

fi3ework commented Jul 15, 2024

Do we need to move fixtures to the root dir from core package? If it's only used by core packages, I think its' good to leave it there.

@Timeless0911
Copy link
Contributor Author

Do we need to move fixtures to the root dir from core package? If it's only used by core packages, I think its' good to leave it there.

It is only used do some unit test for some core functions in core package, so just leave it here. If we need to add global fixtures, we can add them to e2e folder instead.

For autoExtension case, in e2e test, we check the build artifacts to see if the correct file is generated and in unit tests in core package, we just need to check the return value of getDefaultExtension funtion.

@fi3ework
Copy link
Member

image

Sorry, my mistake. I thought this PR moved to the project root dir (the tree indent is too inconspicuous). LGTM.

@fi3ework fi3ework merged commit a230db5 into main Jul 15, 2024
4 checks passed
@fi3ework fi3ework deleted the test/extension branch July 15, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants