Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete js test cases #27

Merged
merged 2 commits into from
Jul 8, 2024
Merged

test: delete js test cases #27

merged 2 commits into from
Jul 8, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

  • update pnpm 9.1.4 -> 9.5.0
  • remove js/ts dir in cases define and alias, we can supersede with a complex js/ts combined case in the future
  • add a setupVitestTests.js to delete test NODE_ENV to avoid affecting the default build config

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from fi3ework July 8, 2024 08:11
@fi3ework
Copy link
Member

fi3ework commented Jul 8, 2024

Bumping pnpm to 9.5.0, we could use https://pnpm.io/catalogs now. We could clean deps in a separated PR.

@Timeless0911
Copy link
Contributor Author

Bumping pnpm to 9.5.0, we could use https://pnpm.io/catalogs now. We could clean deps in a separated PR.

yes, that's why I update it, we can use catalogs in our repo. For Rsbuild repo, renovate does not support it, so we can update this feature later.

@Timeless0911 Timeless0911 merged commit 2c2743e into main Jul 8, 2024
3 checks passed
@Timeless0911 Timeless0911 deleted the test/delete-js-ts branch July 8, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants