Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support platform #26

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: support platform #26

merged 1 commit into from
Jul 8, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Jul 5, 2024

Summary

  • add platform config
  • auto externalize node built-in modules when platform is node

Concern of introducing platform config

  • If we use keep using target field, some config will be changed internally (for now, externalsTypes for built-in modules has changed), which will lead to misalignment between Rsbuild and Rslib.
  • If we using another field, such as platform as of now. output.target will conflict with it, we should drop it from Rsbuild available config for Rslib.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

- add `platform` config
- auto externalize node built-in modules when platform is `node`
@fi3ework
Copy link
Member Author

fi3ework commented Jul 8, 2024

Using platform as a temp solution, it's set to be changed in the future once we made the final config decision.

@fi3ework fi3ework merged commit c568c90 into main Jul 8, 2024
3 checks passed
@fi3ework fi3ework deleted the external branch July 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants