Merge branch 'main' into use-environment-hooks

packages/core/src/build.ts

@@ -1,8 +1,12 @@
+import type { RsbuildInstance } from '@rsbuild/core';
 import type { BuildOptions } from './cli/commands';
 import { initRsbuild } from './config';
 import type { RslibConfig } from './types/config';
 
-export async function build(config: RslibConfig, options?: BuildOptions) {
+export async function build(
+  config: RslibConfig,
+  options?: BuildOptions,
+): Promise<RsbuildInstance> {
   const rsbuildInstance = await initRsbuild(config);
 
   await rsbuildInstance.build({

packages/core/src/cli/commands.ts

@@ -31,7 +31,7 @@ const applyCommonOptions = (command: Command) => {
     );
 };
 
-export function runCli() {
+export function runCli(): void {
   program.name('rslib').usage('<command> [options]').version(RSLIB_VERSION);
 
   const buildCommand = program.command('build');

packages/core/src/cli/prepare.ts

@@ -9,7 +9,7 @@ function initNodeEnv() {
   }
 }
 
-export function prepareCli() {
+export function prepareCli(): void {
   initNodeEnv();
 
   // Print a blank line to keep the greet log nice.

packages/core/src/config.ts

@@ -2,6 +2,7 @@ import fs from 'node:fs';
 import path, { dirname, isAbsolute, join } from 'node:path';
 import {
   type RsbuildConfig,
+  type RsbuildInstance,
   createRsbuild,
   defineConfig as defineRsbuildConfig,
   loadConfig as loadRsbuildConfig,
@@ -473,7 +474,9 @@ export async function composeCreateRsbuildConfig(
   return composedRsbuildConfig;
 }
 
-export async function initRsbuild(rslibConfig: RslibConfig) {
+export async function initRsbuild(
+  rslibConfig: RslibConfig,
+): Promise<RsbuildInstance> {
   const rsbuildConfigObject = await composeCreateRsbuildConfig(rslibConfig);
   const environments: RsbuildConfig['environments'] = {};
   const formatCount: Record<Format, number> = rsbuildConfigObject.reduce(

packages/core/src/index.ts

@@ -8,4 +8,4 @@ export * from './utils/helper';
 
 export * from './types/config';
 
-export const version = RSLIB_VERSION;
+export const version: string = RSLIB_VERSION;

packages/core/src/utils/extension.ts

@@ -7,7 +7,11 @@ export const getDefaultExtension = (options: {
   format: Format;
   root: string;
   autoExtension: boolean;
-}) => {
+}): {
+  jsExtension: string;
+  dtsExtension: string;
+  isModule?: boolean;
+} => {
   const { format, root, autoExtension } = options;
 
   let jsExtension = '.js';

packages/core/src/utils/helper.ts

@@ -5,7 +5,7 @@ import color from 'picocolors';
  * Node.js built-in modules.
  * Copied from https://github.com/webpack/webpack/blob/dd44b206a9c50f4b4cb4d134e1a0bd0387b159a3/lib/node/NodeTargetPlugin.js#L12-L72
  */
-export const nodeBuiltInModules = [
+export const nodeBuiltInModules: Array<string | RegExp> = [
   'assert',
   'assert/strict',
   'async_hooks',

packages/core/src/utils/logger.ts

@@ -6,7 +6,7 @@ if (process.env.DEBUG) {
   logger.level = 'verbose';
 }
 
-export const isDebug = () => {
+export const isDebug = (): boolean => {
   if (!process.env.DEBUG) {
     return false;
   }
@@ -27,7 +27,7 @@ function getTime() {
   return `${hours}:${minutes}:${seconds}`;
 }
 
-export const debug = (message: string | (() => string)) => {
+export const debug = (message: string | (() => string)): void => {
   if (isDebug()) {
     const result = typeof message === 'string' ? message : message();
     const time = color.gray(`${getTime()}`);

packages/core/tsconfig.json

@@ -6,6 +6,7 @@
     "rootDir": "src",
     "declaration": true,
     "declarationDir": "./dist-types",
+    "isolatedDeclarations": true,
     "composite": true,
     "module": "ESNext",
     "moduleResolution": "Bundler",

packages/plugin-dts/src/apiExtractor.ts

@@ -13,7 +13,7 @@ export type BundleOptions = {
   tsconfigPath?: string;
 };
 
-export function bundleDts(options: BundleOptions) {
+export function bundleDts(options: BundleOptions): void {
   const {
     cwd,
     outDir,

packages/plugin-dts/src/dts.ts

@@ -6,7 +6,7 @@ import * as ts from 'typescript';
 import { emitDts } from './tsc';
 import { ensureTempDeclarationDir, loadTsconfig } from './utils';
 
-export async function generateDts(data: DtsGenOptions) {
+export async function generateDts(data: DtsGenOptions): Promise<void> {
   const { options: pluginOptions, cwd, isWatch, name } = data;
   logger.start(`Generating DTS... ${color.gray(`(${name})`)}`);
   const { tsconfigPath, distPath, bundle, entryPath } = pluginOptions;

packages/plugin-dts/src/tsc.ts

@@ -15,7 +15,7 @@ export function emitDts(
   options: emitDtsOptions,
   onComplete: (isSuccess: boolean) => void,
   isWatch = false,
-) {
+): void {
   const start = Date.now();
   const getTimeCost = () => {
     return `${Math.floor(Date.now() - start)}ms`;

packages/plugin-dts/src/utils.ts

@@ -14,7 +14,7 @@ export function loadTsconfig(tsconfigPath: string): ts.ParsedCommandLine {
 }
 
 export const TEMP_FOLDER = '.rslib';
-export const TEMP_DTS_DIR = `${TEMP_FOLDER}/declarations`;
+export const TEMP_DTS_DIR: string = `${TEMP_FOLDER}/declarations`;
 
 export function ensureTempDeclarationDir(cwd: string): string {
   const dirPath = path.join(cwd, TEMP_DTS_DIR);

packages/plugin-dts/tsconfig.json

@@ -5,6 +5,7 @@
     "baseUrl": "./",
     "rootDir": "src",
     "declaration": true,
+    "isolatedDeclarations": true,
     "composite": true,
     "module": "ESNext",
     "moduleResolution": "Bundler"

scripts/tsconfig/base.json

@@ -2,9 +2,10 @@
   "extends": "@tsconfig/strictest/tsconfig",
   "compilerOptions": {
     "exactOptionalPropertyTypes": false,
-    "target": "ES2019",
+    "target": "ES2021",
     "lib": ["DOM", "ESNext"],
-    "allowJs": true,
+    "allowJs": false,
+    "checkJs": false,
     "module": "ES2020",
     "strict": true,
     "isolatedModules": true,