chore: code review

web-infra-dev · Jun 20, 2024 · bc7d9a2 · bc7d9a2
1 parent 0a9caab
commit bc7d9a2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/test-ubuntu.yml b/.github/workflows/test-ubuntu.yml
@@ -100,3 +100,8 @@ jobs:
         run: |
           pnpm run test:artifact
           pnpm run test:e2e
+
+      - name: Examples Test
+        if: steps.changes.outputs.changed == 'true'
+        run: |
+          pnpm run build:examples
diff --git a/package.json b/package.json
@@ -3,6 +3,7 @@
   "private": true,
   "scripts": {
     "build": "cross-env NX_DAEMON=false nx run-many -t build --exclude @examples/* --parallel=10",
+    "build:examples": "cross-env NX_DAEMON=false nx run-many -t build --projects @examples/* --parallel=10",
     "check-dependency-version": "check-dependency-version-consistency .",
     "lint": "biome check . --diagnostic-level=warn",
     "prebundle": "nx run-many -t prebundle",

diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -2,6 +2,7 @@ import fs from 'node:fs';
 import { dirname, isAbsolute, join } from 'node:path';
 import {
   type RsbuildConfig,
+  createRsbuild,
   defineConfig as defineRsbuildConfig,
   mergeRsbuildConfig,
 } from '@rsbuild/core';
@@ -138,7 +139,6 @@ export function convertLibConfigtoRsbuildConfig(
 export async function composeCreateRsbuildConfig(
   rslibConfig: RslibConfig,
 ): Promise<RsbuildConfig[]> {
-  const { mergeRsbuildConfig } = await import('@rsbuild/core');
   const internalRsbuildConfig = await createInternalRsbuildConfig();
 
   const { lib: libConfigsArray, ...sharedRsbuildConfig } = rslibConfig;
@@ -164,12 +164,11 @@ export async function composeCreateRsbuildConfig(
 }
 
 export async function initRsbuild(rslibConfig: RslibConfig) {
-  const { createRsbuild } = await import('@rsbuild/core');
   // TODO: use environment API instead
   const rsbuildConfigArray = await composeCreateRsbuildConfig(rslibConfig);
 
   const rsbuildPromises = rsbuildConfigArray.map(
-    async (rsbuildConfig: RslibConfig) => {
+    async (rsbuildConfig: RsbuildConfig) => {
       return createRsbuild({ rsbuildConfig });
     },
   );

diff --git a/packages/core/src/types/config/index.ts b/packages/core/src/types/config/index.ts
@@ -7,7 +7,7 @@ export interface LibConfig extends RsbuildConfig {
 }
 
 export interface RslibConfig extends RsbuildConfig {
-  lib?: LibConfig[];
+  lib: LibConfig[];
 }
 
 export type ConfigParams = {