fix: rsbuild breaking changes

web-infra-dev · Aug 10, 2024 · 4a48baa · 4a48baa
1 parent 3ca13db
commit 4a48baa
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 54 deletions.
diff --git a/package.json b/package.json
@@ -51,7 +51,7 @@
   },
   "pnpm": {
     "overrides": {
-      "@rspack/core": "npm:@rspack/[email protected]fca07da-20240704070545"
+      "@rspack/core": "npm:@rspack/[email protected]af0452f-20240808052639"
     }
   }
 }
diff --git a/packages/core/src/build.ts b/packages/core/src/build.ts
@@ -10,7 +10,6 @@ export async function build(
   const rsbuildInstance = await initRsbuild(config);
 
   await rsbuildInstance.build({
-    mode: 'production',
     watch: options?.watch,
   });
 

diff --git a/packages/core/src/cli/commands.ts b/packages/core/src/cli/commands.ts
@@ -14,7 +14,7 @@ export type BuildOptions = CommonOptions & {
 };
 
 export type InspectOptions = CommonOptions & {
-  env: RsbuildMode;
+  mode: RsbuildMode;
   output: string;
   verbose?: boolean;
 };
@@ -64,7 +64,7 @@ export function runCli(): void {
         const rslibConfig = await loadConfig(options.config, options.envMode);
         const rsbuildInstance = await initRsbuild(rslibConfig);
         await rsbuildInstance.inspectConfig({
-          env: options.env,
+          mode: options.mode,
           verbose: options.verbose,
           outputPath: options.output,
           writeToDisk: true,

diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -142,6 +142,7 @@ export const composeAutoExternalConfig = (options: {
 
 export async function createInternalRsbuildConfig(): Promise<RsbuildConfig> {
   return defineRsbuildConfig({
+    mode: 'production',
     dev: {
       progressBar: false,
     },

diff --git a/packages/core/tests/__snapshots__/config.test.ts.snap b/packages/core/tests/__snapshots__/config.test.ts.snap
@@ -7,6 +7,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
       "dev": {
         "progressBar": false,
       },
+      "mode": "none",
       "output": {
         "distPath": {
           "js": "./",
@@ -81,6 +82,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
       "dev": {
         "progressBar": false,
       },
+      "mode": "none",
       "output": {
         "distPath": {
           "js": "./",
@@ -153,6 +155,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
       "dev": {
         "progressBar": false,
       },
+      "mode": "none",
       "output": {
         "distPath": {
           "js": "./",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml