feat!: target default to node

web-infra-dev · Nov 11, 2024 · 339e77f · 339e77f
1 parent b821370
commit 339e77f
Show file tree

Hide file tree

Showing 83 changed files with 346 additions and 99 deletions.
diff --git a/examples/express-plugin/rslib.config.ts b/examples/express-plugin/rslib.config.ts
@@ -27,7 +27,4 @@ export default defineConfig({
       },
     },
   ],
-  output: {
-    target: 'node',
-  },
 });
diff --git a/examples/module-federation/mf-react-component/rslib.config.ts b/examples/module-federation/mf-react-component/rslib.config.ts
@@ -55,5 +55,8 @@ export default defineConfig({
       ],
     },
   ],
+  output: {
+    target: 'web',
+  },
   plugins: [pluginReact()],
 });
diff --git a/examples/react-component-bundle-false/rslib.config.ts b/examples/react-component-bundle-false/rslib.config.ts
@@ -35,6 +35,9 @@ export default defineConfig({
       },
     },
   ],
+  output: {
+    target: 'web',
+  },
   plugins: [
     pluginReact({
       swcReactOptions: {

diff --git a/examples/react-component-bundle/rslib.config.ts b/examples/react-component-bundle/rslib.config.ts
@@ -33,6 +33,9 @@ export default defineConfig({
       },
     },
   ],
+  output: {
+    target: 'web',
+  },
   plugins: [
     pluginReact({
       swcReactOptions: {

diff --git a/examples/react-component-umd/rslib.config.ts b/examples/react-component-umd/rslib.config.ts
@@ -17,6 +17,9 @@ export default defineConfig({
       },
     },
   ],
+  output: {
+    target: 'web',
+  },
   plugins: [
     pluginReact({
       swcReactOptions: {

diff --git a/packages/core/rslib.config.ts b/packages/core/rslib.config.ts
@@ -21,6 +21,7 @@ export default defineConfig({
     },
   },
   output: {
+    // TODO: Remove this after bumping Rslib
     target: 'node',
     externals: {
       picocolors: '../compiled/picocolors/index.js',

diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -453,6 +453,7 @@ export async function createConstantRsbuildConfig(): Promise<RsbuildConfig> {
       },
     },
     output: {
+      target: 'node',
       filenameHash: false,
       distPath: {
         js: './',
@@ -558,7 +559,6 @@ const composeFormatConfig = ({
             },
             output: {
               asyncChunks: false,
-
               library: umdName
                 ? {
                     type: 'umd',
@@ -714,7 +714,7 @@ const composeAutoExtensionConfig = (
 
 const composeSyntaxConfig = (
   syntax?: Syntax,
-  target?: RsbuildConfigOutputTarget,
+  target: RsbuildConfigOutputTarget = 'node',
 ): RsbuildConfig => {
   // Defaults to ESNext, Rslib will assume all of the latest JavaScript and CSS features are supported.
   if (syntax) {
@@ -941,7 +941,7 @@ const composeDtsConfig = async (
 };
 
 const composeTargetConfig = (
-  target: RsbuildConfigOutputTarget = 'web',
+  target: RsbuildConfigOutputTarget = 'node',
 ): RsbuildConfig => {
   switch (target) {
     case 'web':

diff --git a/packages/core/src/utils/syntax.ts b/packages/core/src/utils/syntax.ts
@@ -26,10 +26,6 @@ export const LATEST_TARGET_VERSIONS: Record<
 };
 
 const calcEsnextBrowserslistByTarget = (target: RsbuildConfigOutputTarget) => {
-  if (!target) {
-    return [...LATEST_TARGET_VERSIONS.node, ...LATEST_TARGET_VERSIONS.web];
-  }
-
   if (target === 'node') {
     return LATEST_TARGET_VERSIONS.node;
   }
@@ -195,7 +191,7 @@ export function transformSyntaxToRspackTarget(
 
 export function transformSyntaxToBrowserslist(
   syntax: Syntax,
-  target?: NonNullable<RsbuildConfig['output']>['target'],
+  target: NonNullable<RsbuildConfig['output']>['target'],
 ): NonNullable<NonNullable<RsbuildConfig['output']>['overrideBrowserslist']> {
   const handleSyntaxItem = (
     syntaxItem: EcmaScriptVersion | string,

diff --git a/packages/core/tests/__snapshots__/config.test.ts.snap b/packages/core/tests/__snapshots__/config.test.ts.snap
@@ -14,6 +14,62 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
         },
         "externals": [
           [Function],
+          "assert",
+          "assert/strict",
+          "async_hooks",
+          "buffer",
+          "child_process",
+          "cluster",
+          "console",
+          "constants",
+          "crypto",
+          "dgram",
+          "diagnostics_channel",
+          "dns",
+          "dns/promises",
+          "domain",
+          "events",
+          "fs",
+          "fs/promises",
+          "http",
+          "http2",
+          "https",
+          "inspector",
+          "inspector/promises",
+          "module",
+          "net",
+          "os",
+          "path",
+          "path/posix",
+          "path/win32",
+          "perf_hooks",
+          "process",
+          "punycode",
+          "querystring",
+          "readline",
+          "readline/promises",
+          "repl",
+          "stream",
+          "stream/consumers",
+          "stream/promises",
+          "stream/web",
+          "string_decoder",
+          "sys",
+          "timers",
+          "timers/promises",
+          "tls",
+          "trace_events",
+          "tty",
+          "url",
+          "util",
+          "util/types",
+          "v8",
+          "vm",
+          "wasi",
+          "worker_threads",
+          "zlib",
+          /\\^node:/,
+          "pnpapi",
         ],
         "filename": {
           "js": "[name].js",
@@ -40,13 +96,8 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
         },
         "overrideBrowserslist": [
           "last 1 node versions",
-          "last 1 Chrome versions",
-          "last 1 Firefox versions",
-          "last 1 Edge versions",
-          "last 1 Safari versions",
-          "last 1 ios_saf versions",
-          "not dead",
         ],
+        "target": "node",
       },
       "performance": {
         "chunkSplit": {
@@ -141,7 +192,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
           [Function],
           {
             "target": [
-              "web",
+              "node",
             ],
           },
           {
@@ -174,6 +225,64 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
         "distPath": {
           "js": "./",
         },
+        "externals": [
+          "assert",
+          "assert/strict",
+          "async_hooks",
+          "buffer",
+          "child_process",
+          "cluster",
+          "console",
+          "constants",
+          "crypto",
+          "dgram",
+          "diagnostics_channel",
+          "dns",
+          "dns/promises",
+          "domain",
+          "events",
+          "fs",
+          "fs/promises",
+          "http",
+          "http2",
+          "https",
+          "inspector",
+          "inspector/promises",
+          "module",
+          "net",
+          "os",
+          "path",
+          "path/posix",
+          "path/win32",
+          "perf_hooks",
+          "process",
+          "punycode",
+          "querystring",
+          "readline",
+          "readline/promises",
+          "repl",
+          "stream",
+          "stream/consumers",
+          "stream/promises",
+          "stream/web",
+          "string_decoder",
+          "sys",
+          "timers",
+          "timers/promises",
+          "tls",
+          "trace_events",
+          "tty",
+          "url",
+          "util",
+          "util/types",
+          "v8",
+          "vm",
+          "wasi",
+          "worker_threads",
+          "zlib",
+          /\\^node:/,
+          "pnpapi",
+        ],
         "filename": {
           "js": "[name].js",
         },
@@ -199,13 +308,8 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
         },
         "overrideBrowserslist": [
           "last 1 node versions",
-          "last 1 Chrome versions",
-          "last 1 Firefox versions",
-          "last 1 Edge versions",
-          "last 1 Safari versions",
-          "last 1 ios_saf versions",
-          "not dead",
         ],
+        "target": "node",
       },
       "performance": {
         "chunkSplit": {
@@ -298,7 +402,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
           [Function],
           {
             "target": [
-              "web",
+              "node",
             ],
           },
           {
@@ -331,6 +435,64 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
         "distPath": {
           "js": "./",
         },
+        "externals": [
+          "assert",
+          "assert/strict",
+          "async_hooks",
+          "buffer",
+          "child_process",
+          "cluster",
+          "console",
+          "constants",
+          "crypto",
+          "dgram",
+          "diagnostics_channel",
+          "dns",
+          "dns/promises",
+          "domain",
+          "events",
+          "fs",
+          "fs/promises",
+          "http",
+          "http2",
+          "https",
+          "inspector",
+          "inspector/promises",
+          "module",
+          "net",
+          "os",
+          "path",
+          "path/posix",
+          "path/win32",
+          "perf_hooks",
+          "process",
+          "punycode",
+          "querystring",
+          "readline",
+          "readline/promises",
+          "repl",
+          "stream",
+          "stream/consumers",
+          "stream/promises",
+          "stream/web",
+          "string_decoder",
+          "sys",
+          "timers",
+          "timers/promises",
+          "tls",
+          "trace_events",
+          "tty",
+          "url",
+          "util",
+          "util/types",
+          "v8",
+          "vm",
+          "wasi",
+          "worker_threads",
+          "zlib",
+          /\\^node:/,
+          "pnpapi",
+        ],
         "filename": {
           "js": "[name].js",
         },
@@ -356,13 +518,8 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
         },
         "overrideBrowserslist": [
           "last 1 node versions",
-          "last 1 Chrome versions",
-          "last 1 Firefox versions",
-          "last 1 Edge versions",
-          "last 1 Safari versions",
-          "last 1 ios_saf versions",
-          "not dead",
         ],
+        "target": "node",
       },
       "performance": {
         "chunkSplit": {
@@ -437,7 +594,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
           [Function],
           {
             "target": [
-              "web",
+              "node",
             ],
           },
           {

diff --git a/packages/core/tests/config.test.ts b/packages/core/tests/config.test.ts
@@ -217,12 +217,6 @@ describe('syntax', () => {
     ).toMatchInlineSnapshot(`
       [
         "last 1 node versions",
-        "last 1 Chrome versions",
-        "last 1 Firefox versions",
-        "last 1 Edge versions",
-        "last 1 Safari versions",
-        "last 1 ios_saf versions",
-        "not dead",
       ]
     `);
   });

diff --git a/packages/create-rslib/fragments/base/node-dual-js/rslib.config.mjs b/packages/create-rslib/fragments/base/node-dual-js/rslib.config.mjs
@@ -11,5 +11,4 @@ export default defineConfig({
       syntax: 'es2021',
     },
   ],
-  output: { target: 'node' },
 });
diff --git a/packages/create-rslib/fragments/base/node-dual-ts/rslib.config.ts b/packages/create-rslib/fragments/base/node-dual-ts/rslib.config.ts
@@ -12,5 +12,4 @@ export default defineConfig({
       syntax: 'es2021',
     },
   ],
-  output: { target: 'node' },
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,4 @@ export default defineConfig({ @@
           },
         },
       ],
-      output: {
-        target: 'node',
-      },
     });