feat: use "module-import" in ESM (#73)

web-infra-dev · Aug 8, 2024 · 12066db · 12066db
1 parent 109a00a
commit 12066db
Show file tree

Hide file tree

Showing 5 changed files with 54 additions and 54 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -123,4 +123,4 @@ The project is still in its early stages and under active development, so it pos
 
 | Package      | Link                                                    |
 | ------------ | ------------------------------------------------------- |
-| @rspack/core | [PR](https://github.com/web-infra-dev/rspack/pull/7394) |
+| @rspack/core | [PR](https://github.com/web-infra-dev/rspack/pull/7493) |
diff --git a/package.json b/package.json
@@ -51,7 +51,7 @@
   },
   "pnpm": {
     "overrides": {
-      "@rspack/core": "npm:@rspack/[email protected]338cfbe-20240731183605"
+      "@rspack/core": "npm:@rspack/[email protected]af0452f-20240808052639"
     }
   }
 }
diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -114,7 +114,7 @@ const composeFormatConfig = (format: Format): RsbuildConfig => {
       return {
         tools: {
           rspack: {
-            externalsType: 'module',
+            externalsType: 'module-import',
             output: {
               module: true,
               chunkFormat: 'module',

diff --git a/packages/core/tests/__snapshots__/config.test.ts.snap b/packages/core/tests/__snapshots__/config.test.ts.snap
@@ -41,7 +41,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
             "experiments": {
               "outputModule": true,
             },
-            "externalsType": "module",
+            "externalsType": "module-import",
             "optimization": {
               "concatenateModules": true,
             },

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml