Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rsdoctor plugin tag #434

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: add rsdoctor plugin tag #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8168b8
fix: add rsdoctor plugin tag
easy1090 Jul 22, 2024
5c6dc63
Merge branch 'main' into fix/add-plugin-tag
easy1090 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/types/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export interface RsdoctorPluginInstance<
readonly name: string;
readonly options: RsdoctorPluginOptionsNormalized<Rules>;
readonly sdk: RsdoctorWebpackSDK;
readonly isRsdoctorPlugin: boolean;
_modulesGraphApplied?: boolean;
chunkGraph?: ChunkGraph;
modulesGraph: ModuleGraph;
Expand Down
3 changes: 3 additions & 0 deletions packages/rspack-plugin/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ export class RsdoctorRspackPlugin<Rules extends Linter.ExtendRuleData[]>

public readonly sdk: RsdoctorWebpackSDK | RsdoctorSlaveSDK;

public readonly isRsdoctorPlugin: boolean;

public _bootstrapTask!: Promise<unknown>;

protected browserIsOpened = false;
Expand Down Expand Up @@ -72,6 +74,7 @@ export class RsdoctorRspackPlugin<Rules extends Linter.ExtendRuleData[]>
});
this.outsideInstance = Boolean(this.options.sdkInstance);
this.modulesGraph = new ModuleGraph();
this.isRsdoctorPlugin = true;
}

// avoid hint error from ts type validation
Expand Down
3 changes: 3 additions & 0 deletions packages/webpack-plugin/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ export class RsdoctorWebpackPlugin<Rules extends Linter.ExtendRuleData[]>

public readonly sdk: RsdoctorWebpackSDK;

public readonly isRsdoctorPlugin: boolean;

public modulesGraph: ModuleGraph;

private outsideInstance = false;
Expand All @@ -64,6 +66,7 @@ export class RsdoctorWebpackPlugin<Rules extends Linter.ExtendRuleData[]>
this.outsideInstance = Boolean(this.options.sdkInstance);
this.modulesGraph = new ModuleGraph();
this.chunkGraph = new ChunkGraph();
this.isRsdoctorPlugin = true;
}

// avoid hint error from ts type validation
Expand Down
Loading