Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to load Rsdoctor package in Windows #3417

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: failed to load Rsdoctor package in Windows #3417

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2b1106
fix: failed to load Rsdoctor package in Windows
chenjiahan Sep 9, 2024
83eb730
fix
chenjiahan Sep 17, 2024
5c55388
fix
chenjiahan Sep 17, 2024
7b9d0d3
fix: failed to load Rsdoctor package in Windows
easy1090 Sep 23, 2024
3ca02a9
fix: failed to load Rsdoctor package in Windows
easy1090 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/plugins/rsdoctor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { pathToFileURL } from 'node:url';
import type { Configuration } from '@rspack/core';
import color from 'picocolors';
import { logger } from '../logger';
import type { BundlerPluginInstance, RsbuildPlugin } from '../types';
import path from 'node:path';

type RsdoctorExports = {
RsdoctorRspackPlugin: { new (): BundlerPluginInstance };
Expand Down Expand Up @@ -61,7 +63,8 @@ export const pluginRsdoctor = (): RsbuildPlugin => ({

let module: RsdoctorExports;
try {
module = await import(packagePath);
const modulePath = pathToFileURL(path.resolve(packagePath)).href;
module = await import(modulePath);
} catch (err) {
logger.error(
`\`process.env.RSDOCTOR\` enabled, but failed to load ${color.bold(color.yellow(packageName))} module.`,
Expand Down
Loading