Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(landingpage): new landingpage aligned with Rspack #3349

Merged
merged 12 commits into from
Sep 3, 2024
Merged

docs(landingpage): new landingpage aligned with Rspack #3349

merged 12 commits into from
Sep 3, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Sep 2, 2024 •
edited
Loading

Summary

before
image

v1

image

v2

image

Related Links

web-infra-dev/rspack#7550

@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 53a1e58
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66d6b9c620a8ad00084c97c0
😎 Deploy Preview https://deploy-preview-3349--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 72 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter marked this pull request as draft September 2, 2024 09:30
@SoonIter SoonIter requested a review from chenjiahan September 2, 2024 12:26
chenjiahan
chenjiahan reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo image flickers. We can preset a height for the logo:

  • before:

image

  • after:

image

This was referenced Sep 3, 2024
Merged
Merged
Merged
@SoonIter SoonIter requested a review from chenjiahan September 3, 2024 04:21
@SoonIter SoonIter marked this pull request as ready for review September 3, 2024 05:25
chenjiahan
chenjiahan reviewed Sep 3, 2024
View reviewed changes
website/i18n.json Outdated Show resolved Hide resolved
website/theme/components/Hero.tsx Outdated Show resolved Hide resolved
website/theme/components/WhyRsbuild.tsx Outdated Show resolved Hide resolved
website/theme/pages/index.tsx Outdated Show resolved Hide resolved
@SoonIter SoonIter requested a review from chenjiahan September 3, 2024 06:33
chenjiahan
chenjiahan reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we increase the bottom padding to align with the top padding:

image

chenjiahan
chenjiahan approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@chenjiahan chenjiahan merged commit 3e592fa into web-infra-dev:main Sep 3, 2024
9 checks passed
@SoonIter
Copy link
Member Author

SoonIter commented Sep 3, 2024

It is worth noting that our theme color is the same as Rspack.

image

@chenjiahan chenjiahan mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @chenjiahan