Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uni-builder): no need to set html-webpack-plugin #6685

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Jan 2, 2025

Summary

rsbuild already use html-webpack-plugin by default in webpack mode.

web-infra-dev/rsbuild#4175

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 32772eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit 32772eb
🔍 Latest deploy log https://app.netlify.com/sites/modernjs-byted/deploys/67764ca0f1944000086961ff
😎 Deploy Preview https://deploy-preview-6685--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy requested a review from chenjiahan January 2, 2025 09:04
@chenjiahan chenjiahan changed the title fix: no need to set html-webpack-plugin fix(uni-builder): no need to set html-webpack-plugin Jan 2, 2025
@chenjiahan chenjiahan merged commit b49527a into main Jan 2, 2025
11 checks passed
@chenjiahan chenjiahan deleted the remove-html-webpack-plugin branch January 2, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants