Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support loadable with async entry #6639

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

zllkjc
Copy link
Member

@zllkjc zllkjc commented Dec 16, 2024

Summary

In this PR, we support preload entrypoint's assets when we enable async entry and use loadable.

and it's already support in React 18 Streaming SSR with React Lazy.

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 635d44e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit 635d44e
🔍 Latest deploy log https://app.netlify.com/sites/modernjs-byted/deploys/67600c65d074160008bfbd43
😎 Deploy Preview https://deploy-preview-6639--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zllkjc zllkjc force-pushed the feat/loadable-prefetch branch from 1845acf to 635d44e Compare December 16, 2024 11:17
@caohuilin caohuilin merged commit eab6089 into main Dec 17, 2024
11 checks passed
@caohuilin caohuilin deleted the feat/loadable-prefetch branch December 17, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants