feat: collect async hook support params and fix garfish test

packages/solutions/app-tools/src/new/compat/hooks.ts

@@ -80,6 +80,14 @@ export function getHookRunners(
     beforePrintInstructions: async (params: { instructions: string }) => {
       return hooks.onBeforePrintInstructions.call(params);
     },
+    // garfish plugin hooks
+    appendEntryCode: async (params: {
+      entrypoint: Entrypoint;
+      code: string;
+    }) => {
+      const result = await (hooks as any)?.appendEntryCode.call(params);
+      return result;
+    },
 
     /**
      * common hooks

packages/solutions/app-tools/src/new/compat/index.ts

@@ -1,11 +1,18 @@
+import { createCollectAsyncHook } from '@modern-js/plugin-v2';
 import type { InternalContext, Plugin } from '@modern-js/plugin-v2/types';
+import type { Entrypoint } from '@modern-js/types';
 import type {
   AppToolsNormalizedConfig,
   AppToolsUserConfig,
 } from '../../types/config';
 import type { AppTools, AppToolsExtendAPIName } from '../types';
 import { getHookRunners } from './hooks';
 
+type AppendEntryCodeFn = (params: {
+  entrypoint: Entrypoint;
+  code: string;
+}) => string | Promise<string>;
+
 export const compatPlugin = (): Plugin<
   AppTools<'shared'>,
   InternalContext<
@@ -38,5 +45,8 @@ export const compatPlugin = (): Plugin<
       },
     };
   },
+  registryHooks: {
+    appendEntryCode: createCollectAsyncHook<AppendEntryCodeFn>(),
+  },
   setup: _api => {},
 });

packages/toolkit/plugin-v2/src/hooks.ts

@@ -29,18 +29,18 @@ export function createAsyncHook<
 }
 
 export function createCollectAsyncHook<
-  Callback extends () => any,
+  Callback extends (...params: any[]) => any,
 >(): CollectAsyncHook<Callback> {
   const callbacks: Callback[] = [];
 
   const tap = (cb: Callback) => {
     callbacks.push(cb);
   };
 
-  const call = async () => {
+  const call = async (...params: Parameters<Callback>) => {
     const results: UnwrapPromise<ReturnType<Callback>>[] = [];
     for (const callback of callbacks) {
-      const result = await callback();
+      const result = await callback(params);
 
       if (result !== undefined) {
         results.push(result);

packages/toolkit/plugin-v2/src/types/hooks.ts

@@ -5,9 +5,11 @@ export type AsyncHook<Callback extends (...args: any[]) => any> = {
   call: (...args: Parameters<Callback>) => Promise<Parameters<Callback>>;
 };
 
-export type CollectAsyncHook<Callback extends () => any> = {
+export type CollectAsyncHook<Callback extends (...params: any[]) => any> = {
   tap: (cb: Callback) => void;
-  call: () => Promise<UnwrapPromise<ReturnType<Callback>>[]>;
+  call: (
+    ...params: Parameters<Callback>
+  ) => Promise<UnwrapPromise<ReturnType<Callback>>[]>;
 };
 
 export type PluginHook<Callback extends (...args: any[]) => any> =