Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse CHAIN_ID from Rsbuild #5410

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

chenjiahan
Copy link
Member

Summary

  • reuse CHAIN_ID from Rsbuild, avoid maintaining two copies of CHAIN_ID.
  • remove some outdated dependency configs.

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Feb 20, 2024

⚠️ No Changeset found

Latest commit: 7629498

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chenjiahan chenjiahan requested a review from 9aoy February 20, 2024 08:15
@chenjiahan chenjiahan enabled auto-merge (squash) February 20, 2024 08:25
@chenjiahan chenjiahan merged commit a3a788b into web-infra-dev:main Feb 20, 2024
8 checks passed
@chenjiahan chenjiahan deleted the clean_up_builder_0220 branch February 20, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants