-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove ajv schema verification of modern configuration #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca005c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 268 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zllkjc
force-pushed
the
deprecated/ajv
branch
2 times, most recently
from
November 6, 2023 04:10
1a36507
to
652c8af
Compare
chenjiahan
reviewed
Nov 6, 2023
zllkjc
force-pushed
the
deprecated/ajv
branch
from
November 6, 2023 06:13
4b30775
to
ca005c3
Compare
chenjiahan
approved these changes
Nov 6, 2023
👏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Modern.js, running Ajv causes every CLI command to take an extra 50~150ms of time.
We found that the vast of users do not rely on schema verification, it can accurately filter configuration errors through type definition.
So we decide to remove Ajv, depends only on
.ts
config file.Summary
🤖 Generated by Copilot at 4417a73
Removed the
Ajv
-based config validation feature from the core and the plugins of themodern.js
CLI. This feature was unnecessary and complicated the codebase. Deleted the files and code related to the config validation schemas, thevalidateSchema
hooks, and therepeatKeyWarning
utility. Updated the function calls and types to reflect the changes.Details
🤖 Generated by Copilot at 4417a73
Ajv
and the schema-related code and arguments from the core and the plugins (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)createResolveConfig
function call increateCli.ts
to match the new signature of the function (link)validateSchema
workflow from themanager
object inmanager.ts
and theBaseHooks
type inhooks.ts
(link, link)onSchemaError
property from theCoreOptions
interface incoreOptions.ts
(link, link)PluginValidateSchema
interface fromindex.ts
(link, link)repeatKeyWarning
export fromutils/index.ts
(link)validateSchema
hook from thebff
,proxy
,ssg
,swc
,tailwind
, anddesignToken
plugins in their respective files (link, link, link, link, link, link)validateSchema
hook from thebff
,proxy
, anddesignToken
plugins in their respective files (link, link, link)traverseSchema.ts
,patchSchema.ts
,repeatKeyWarning.ts
,repeatKeyWarning.test.ts
, andschema.test.ts
as they are no longer needed (link, link, link, link, link)Related Issue
Checklist
pnpm run change
.