-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(builder): update rspack to 0.3.10 and fix deprecate warning #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b33660 The changes in this PR will be included in the next version bump. This PR includes changesets to release 268 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chenjiahan
previously approved these changes
Nov 4, 2023
chenjiahan
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 2e870ab
This pull request enhances the node polyfills and react refresh support for both rspack and webpack bundlers by using the
ProvidePlugin
from themodifyBundlerChain
hook. It also updates the dependencies and types of the@modern-js/builder-rspack-provider
package and refactors some plugin and utility functions for simplicity and consistency.Details
🤖 Generated by Copilot at 2e870ab
@rspack/core
and its plugins to 0.3.10 and useProvidePlugin
to inject global variables for node polyfills and react refresh runtime (link, link, link, link, link, link, link, link, link)builtins.provide
in the rspack config by using theProvidePlugin
from themodifyBundlerChain
hook instead (link, link)@modern-js/builder-rspack-provider
package and the reason for it (link)utils
parameter in theisUsingHMR
function to only include theisProd
andtarget
properties (link)setConfig
function from the@modern-js/plugin-node-polyfill
package (link)CHAIN_ID
andbundler
properties to theutils
parameter in thebuilderPluginNodePolyfill
function to name the plugin instance and access theProvidePlugin
(link)Related Issue
Checklist
pnpm run change
.