-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module-tools): change the output css module json filename #4774
Conversation
🦋 Changeset detectedLatest commit: c6d6560 The changes in this PR will be included in the next version bump. This PR includes changesets to release 257 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b6071c9
to
4fab7af
Compare
4fab7af
to
c6d6560
Compare
Oh, it can not avoid the esbuild error. |
We need a more hack way |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4774 +/- ##
==========================================
- Coverage 57.59% 51.18% -6.42%
==========================================
Files 672 680 +8
Lines 17794 18970 +1176
Branches 3876 4383 +507
==========================================
- Hits 10249 9709 -540
- Misses 6934 8530 +1596
- Partials 611 731 +120 ☔ View full report in Codecov by Sentry. |
LGTM 👍🏻 |
fix #4711
Summary
🤖 Generated by Copilot at b6071c9
This pull request changes the output css module json filename when bundleless, to avoid naming conflicts. It also refactors and moves the
isCssModule
function to theutils
module, and updates the related code and tests. It adds a changeset file for the@modern-js/module-tools
package.Details
🤖 Generated by Copilot at b6071c9
@modern-js/module-tools
package (link)isCssModule
function from thepostcssTransformer
module to theutils
module, and update the imports accordingly (link, link, link, link)esbuild
builder itself (link)basename
function from thepath
module, to generate the new css module json filename (link)redirect
feature, to match the new css module json filename (link, link)Related Issue
Checklist
pnpm run change
.