fix(bff): zodError causing 500 error due to inconsistent zod versions

web-infra-dev · Oct 15, 2024 · fa79523 · fa79523
1 parent a33d0da
commit fa79523
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 18 deletions.
diff --git a/.changeset/nervous-humans-chew.md b/.changeset/nervous-humans-chew.md
@@ -0,0 +1,5 @@
+---
+'@modern-js/bff-core': patch
+---
+
+fix(bff): zodError causing 500 error due to inconsistent zod versions
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -42,7 +42,7 @@
     "**/node_modules": false
   },
   "[typescript]": {
-    "editor.defaultFormatter": "biomejs.biome",
+    "editor.defaultFormatter": "vscode.typescript-language-features",
     "editor.codeActionsOnSave": {
       "quickfix.biome": "explicit",
       "source.organizeImports": "never",

diff --git a/packages/server/bff-core/src/operators/http.ts b/packages/server/bff-core/src/operators/http.ts
@@ -21,9 +21,8 @@ const validateInput = async <Schema extends z.ZodType>(
 ): Promise<z.output<Schema>> => {
   try {
     return await schema.parseAsync(input);
-  } catch (error) {
-    const { z: zod } = await import('zod');
-    if (error instanceof zod.ZodError) {
+  } catch (error: any) {
+    if ('name' in error && error.name === 'ZodError') {
       throw new ValidationError(400, error.message);
     }
     throw error;

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml