fix(app-tools): align resolve.modules config in rspack mode (#4762)

web-infra-dev · Oct 10, 2023 · c1b0d18 · c1b0d18
1 parent e27c843
commit c1b0d18
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/.changeset/perfect-dolphins-begin.md b/.changeset/perfect-dolphins-begin.md
@@ -0,0 +1,8 @@
+---
+'@modern-js/builder-shared': patch
+'@modern-js/app-tools': patch
+---
+
+fix(app-tools): align resolve.modules config in rspack mode
+
+fix(app-tools): 对齐 rspack 模式下的 resolve.modules 配置
diff --git a/packages/builder/builder-shared/src/types/bundlerConfig.ts b/packages/builder/builder-shared/src/types/bundlerConfig.ts
@@ -38,6 +38,7 @@ type RspackResolve = {
   conditionNames?: string[];
   alias?: Record<string, false | string | string[]>;
   tsConfigPath?: string;
+  modules?: string[];
   fallback?: Record<string, false | string>;
 };
 

diff --git a/packages/solutions/app-tools/src/builder/builder-webpack/adapterModern.ts b/packages/solutions/app-tools/src/builder/builder-webpack/adapterModern.ts
@@ -1,4 +1,3 @@
-import { join } from 'path';
 import { BuilderPlugin } from '@modern-js/builder-shared';
 import type { BuilderPluginAPI } from '@modern-js/builder-webpack-provider';
 import { BuilderOptions } from '../shared';
@@ -16,11 +15,6 @@ export const builderPluginAdapterModern = (
     const { normalizedConfig: modernConfig, appContext } = options;
 
     api.modifyWebpackChain((chain, { CHAIN_ID }) => {
-      // compat modern-js v1
-      chain.resolve.modules
-        .add('node_modules')
-        .add(join(api.context.rootPath, 'node_modules'));
-
       // apply copy plugin
       if (chain.plugins.has(CHAIN_ID.PLUGIN.COPY)) {
         const defaultCopyPattern = createPublicPattern(

diff --git a/packages/solutions/app-tools/src/builder/shared/builderPlugins/adapterBasic.ts b/packages/solutions/app-tools/src/builder/shared/builderPlugins/adapterBasic.ts
@@ -1,3 +1,4 @@
+import path from 'path';
 import { BuilderPlugin, BundlerChain } from '@modern-js/builder-shared';
 import type { BuilderPluginAPI } from '../types';
 
@@ -34,6 +35,12 @@ export const builderPluginAdapterBasic =
             .use('server-module-loader')
             .loader(require.resolve('../loaders/serverModuleLoader'));
         }
+
+        // compat modern-js v1
+        // this helps symlinked packages to resolve packages correctly, such as `react/jsx-runtime`.
+        chain.resolve.modules
+          .add('node_modules')
+          .add(path.join(api.context.rootPath, 'node_modules'));
       });
     },
   });