fix(plugin-garfish): only override assetPrefix default value (#4725)

* fix(plugin-garfish): only override assetPrefix default value * fix: test
web-infra-dev · Sep 26, 2023 · b05b24b · b05b24b
1 parent 9ab3eb0
commit b05b24b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/.changeset/red-hairs-knock.md b/.changeset/red-hairs-knock.md
@@ -0,0 +1,7 @@
+---
+'@modern-js/plugin-garfish': patch
+---
+
+fix(plugin-garfish): only override assetPrefix default value
+
+fix(plugin-garfish): 只对 assetPrefix 的默认值进行覆盖
diff --git a/packages/runtime/plugin-garfish/src/cli/index.ts b/packages/runtime/plugin-garfish/src/cli/index.ts
@@ -177,8 +177,19 @@ export const garfishPlugin = ({
               const resolveOptions = useResolvedConfigContext();
               if (resolveOptions?.deploy?.microFrontend) {
                 chain.output.libraryTarget('umd');
-                if (
+
+                const DEFAULT_ASSET_PREFIX = '/';
+
+                // Only override assetPrefix when using the default asset prefix,
+                // this allows user or other plugins to set asset prefix.
+                const resolvedAssetPrefix = resolveOptions.dev?.assetPrefix;
+                const isUsingDefaultAssetPrefix =
                   !useConfig.dev?.assetPrefix &&
+                  (!resolvedAssetPrefix ||
+                    resolvedAssetPrefix === DEFAULT_ASSET_PREFIX);
+
+                if (
+                  isUsingDefaultAssetPrefix &&
                   resolveOptions?.server?.port &&
                   env === 'development'
                 ) {