chore: enhance unknown error logger (#4647)

* fix: we can use console-trace to follow unknown error call stack * chore: add changeset
web-infra-dev · Sep 14, 2023 · 843cb2c · 843cb2c
1 parent be6cb8f
commit 843cb2c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/slimy-seals-battle.md b/.changeset/slimy-seals-battle.md
@@ -0,0 +1,6 @@
+---
+'@modern-js/core': patch
+---
+
+fix(core): we should not pass it, if err is not instanceof Error.
+fix(core): 如果 err 不属于错误，我们不应该直接丢弃它
diff --git a/packages/cli/core/src/createCli.ts b/packages/cli/core/src/createCli.ts
@@ -99,6 +99,10 @@ export const createCli = () => {
           hooksRunner.beforeExit();
           if (err instanceof Error) {
             logger.error(err.stack);
+          } else {
+            // We should not pass it, if err is not instanceof Error.
+            // We can use `console.trace` to follow it call stack,
+            console.trace('Unknown Error', err);
           }
           process.nextTick(() => {
             // eslint-disable-next-line no-process-exit