fix(server): use cjs format hmr-client to fix hmr issue (#4719)

web-infra-dev · Sep 25, 2023 · 3dcad90 · 3dcad90
1 parent 9c49cf3
commit 3dcad90
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/.changeset/few-knives-jam.md b/.changeset/few-knives-jam.md
@@ -0,0 +1,7 @@
+---
+'@modern-js/server': patch
+---
+
+fix(server): use cjs format hmr-client to fix hmr issue
+
+fix(server): 使用 cjs 格式的 hmr-client 来修复 hmr 问题
diff --git a/packages/server/server/package.json b/packages/server/server/package.json
@@ -32,10 +32,9 @@
     "./hmr-client": {
       "node": {
         "jsnext:source": "./src/dev-tools/dev-middleware/hmr-client/index.ts",
-        "import": "./dist/esm/dev-tools/dev-middleware/hmr-client/index.js",
         "require": "./dist/cjs/dev-tools/dev-middleware/hmr-client/index.js"
       },
-      "default": "./dist/esm/dev-tools/dev-middleware/hmr-client/index.js"
+      "default": "./dist/cjs/dev-tools/dev-middleware/hmr-client/index.js"
     }
   },
   "scripts": {

diff --git a/packages/server/server/src/dev-tools/dev-middleware/index.ts b/packages/server/server/src/dev-tools/dev-middleware/index.ts
@@ -1,4 +1,3 @@
-import { sep } from 'path';
 import { Server } from 'http';
 import { EventEmitter } from 'events';
 import {
@@ -28,10 +27,7 @@ function getHMRClientPath(client: DevServerOptions['client']) {
   )}?${host}${path}${port}${protocol}`;
 
   // replace cjs with esm because we want to use the es5 version
-  return clientEntry.replace(
-    `${sep}cjs${sep}dev-tools`,
-    `${sep}esm${sep}dev-tools`,
-  );
+  return clientEntry;
 }
 
 export default class DevMiddleware extends EventEmitter {