Skip to content

Commit

Permalink
fix(devtools): exports & dist files definition (#4812)
Browse files Browse the repository at this point in the history
  • Loading branch information
Asuka109 authored Oct 18, 2023
1 parent 078444a commit 03a0481
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 30 deletions.
5 changes: 3 additions & 2 deletions packages/devtools/client/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@modern-js/devtools-client",
"version": "2.36.0",
"main": "./index.js",
"scripts": {
"reset": "npx rimraf ./**/node_modules",
"dev": "modern dev",
Expand All @@ -15,6 +14,9 @@
"engines": {
"node": ">=14.0.0"
},
"files": [
"dist"
],
"devDependencies": {
"@modern-js-app/eslint-config": "workspace:*",
"@modern-js/app-tools": "workspace:*",
Expand Down Expand Up @@ -56,6 +58,5 @@
"valtio": "^1.11.1"
},
"dependencies": {
"thumbhash": "^0.1.1"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@

.info-card {
flex: 2;
min-width: 15rem;
min-width: max-content;
}

.indicate-bar {
Expand Down
4 changes: 2 additions & 2 deletions packages/devtools/client/src/routes/overview/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const Page: React.FC = () => {
>
<img src={srcHeading} style={{ width: '8rem' }} />
<Flex gap="2">
<button type="button">v2.35.1</button>
<button type="button">v{store.version}</button>
</Flex>
<Text as="p" size="1">
Powered by {toolsPackage}@{toolsPackageVer}
Expand All @@ -75,7 +75,7 @@ const Page: React.FC = () => {
</Theme>
</IndicateCard>
<IndicateCard className={styles.infoCard}>
<Flex justify="between" align="center" height="100%">
<Flex justify="between" gap="3" align="center" height="100%">
<Box>
<Text color="gray">Visit our website</Text>
<Flex align="center" asChild>
Expand Down
4 changes: 3 additions & 1 deletion packages/devtools/kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"url": "https://github.com/web-infra-dev/modern.js",
"directory": "packages/cli/plugin-tailwind"
},
"files": [
"dist"
],
"license": "MIT",
"keywords": [
"react",
Expand Down Expand Up @@ -49,7 +52,6 @@
"test": "jest --passWithNoTests"
},
"dependencies": {
"@geist-ui/core": "^2.3.8",
"@modern-js/types": "workspace:*",
"@modern-js/utils": "workspace:*",
"@radix-ui/themes": "^2.0.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/devtools/mount/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"engines": {
"node": ">=14.0.0"
},
"files": [
"dist"
],
"dependencies": {
},
"devDependencies": {
Expand Down
7 changes: 5 additions & 2 deletions packages/devtools/plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@
],
"version": "2.36.0",
"jsnext:source": "./src/index.ts",
"types": "./src/index.ts",
"types": "./dist/index.d.ts",
"main": "./dist/index.js",
"files": [
"dist"
],
"exports": {
".": {
"node": {
Expand All @@ -39,7 +42,7 @@
"scripts": {
"prepublishOnly": "only-allow-pnpm",
"new": "modern-lib new",
"dev": "modern-lib build --watch --no-dts",
"dev": "modern-lib build --watch",
"build": "modern-lib build",
"test": "jest --passWithNoTests"
},
Expand Down
1 change: 1 addition & 0 deletions packages/devtools/plugin/src/rpc/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export const setupClientConnection = async (
Object.assign(ret.name, def.name);
Object.assign(ret.packages, def.packages);
Object.assign(ret.assets, def.assets);
Object.assign(ret.announcement, def.announcement);
return ret;
},
echo(content) {
Expand Down
22 changes: 0 additions & 22 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 03a0481

Please sign in to comment.