Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TemplateManager.findAttributeValue对值为空的HTML布尔属性处理错误 #660

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

lzyang1995
Copy link
Contributor

Description

修复的问题参考此issue
改动点:

  • 将findAttributeValue中的||修改为??
  • 对逻辑受影响的地方进行调整(包含两处:packages/core/src/module/resource.ts中的crossorigin,以及packages/core/src/module/app.ts中的no-entry。其他使用findAttributeValue的地方目测不受影响)

Related Issue

#659

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
garfish ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 5:25pm

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e6832e0) 83.31% compared to head (78ea9fa) 83.31%.

Files Patch % Lines
packages/core/src/module/resource.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   83.31%   83.31%   -0.01%     
==========================================
  Files          90       90              
  Lines       12492    12494       +2     
  Branches     1931     1935       +4     
==========================================
+ Hits        10408    10409       +1     
- Misses       2069     2071       +2     
+ Partials       15       14       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoushaw zhoushaw merged commit 9a61e57 into web-infra-dev:main Feb 18, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants