variable 'domain' name conflict resolved #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EventEmitter has variable named 'domain'. So, 'domain' in smtp.js is convert to 'domainName'
|
Would it be possible to merge this commit? It seems pretty harmful and it would be great to be able to use this module with recent node versions. |
|
@pjparra you can merge as fast-forward. I modify just variable name to This screen shot is merge message in my local repo. Sorry for my bad english. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventEmitter has variable named 'domain'.
So, 'domain' in smtp.js is convert to 'domainName'